same as pull request 16 for upstream (making pullrequest just to say thanks for your requests 10 & 11 in upstream :) )#1
Open
cherehapa wants to merge 8 commits intomarkatom:masterfrom
Conversation
…ned result.ast (apply dougbeasley@f7fcb8a)
…rint-validator/pull/12/files (use requireBlueprintName arg option)
…ain also encoding.
…ned - validate via ajv module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
protagonist@1.0.0 (by markatom) + option fail-on-wornings (by markatom): just a merge of changes requested by markatom in pull requests Compatibility with protagonist@1.0.0 and newer JakubOnderka/api-blueprint-validator#10 & Add cli option fail-on-warnings JakubOnderka/api-blueprint-validator#11
option requireBlueprintName (by dougbeasley): similar to changes requested by dougbeasley in pull request Add check for undefined values JakubOnderka/api-blueprint-validator#14
fix isJsonContentType() (by cherehapa): determine json by regexp: Content-type may contain also encoding, i.e. allow headers like:
Content-Type: application/json; charset=utf-8
(no pull requests yet w/ similar functionality (up to 2016Dec9)).
check schemas & their definitions (by cherehapa): if blueprint defines "+Schema", then it should appear in .schema after protagonist.parse. We add check of it to be a correct json (whish is similar to Bug - deprecated protagonist settings JakubOnderka/api-blueprint-validator#15 (except logging improvement, which is not needed in our case)) + add check of it for json schema rules via ajv schema validator module (no pull requests yet w/ similar functionality(up to 2016Dec9)).