ENG-4369: Update golangci-lint to 2.11.3 via mise

[oschwald]

Summary

• Pin golangci-lint 2.11.3 via mise.toml + mise.lock
• Replace golangci-lint GHA with jdx/mise-action + direct run

Test plan

• golangci-lint run ./... passes locally
• CI passes on PR

🤖 Generated with Claude Code

[github-actions]

Modver result

This report was generated by Modver,
a Go package and command that helps you obey semantic versioning rules in your Go module.

This PR does not require a change in your module’s version number.
(You might still consider bumping the patchlevel anyway.)

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the golangci-lint version used in the project to 2.11.3. It leverages the mise tool to manage and pin the golangci-lint version, ensuring consistency across different environments. The changes also streamline the CI workflow by using jdx/mise-action to directly run golangci-lint, which simplifies the configuration and improves reliability.

Highlights

• golangci-lint Update: The pull request updates golangci-lint to version 2.11.3, managed via mise.
• Mise Configuration: It introduces mise.toml and mise.lock files to pin the golangci-lint version and manage tool versions.
• CI Workflow: The pull request replaces the existing golangci-lint GitHub Action with jdx/mise-action for direct execution.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/golangci-lint.yml

Activity

• The PR introduces mise for managing golangci-lint.
• It replaces the existing GHA workflow with a mise-based approach.
• The test plan includes local golangci-lint checks and CI pipeline validation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces mise for managing tool versions, but it has critical issues. The versions for go and golangci-lint specified in mise.toml as latest resolve to non-existent versions (1.26.1 and 2.11.3 respectively) in mise.lock. This will cause the developer setup to fail. I have provided suggestions to pin to valid, existing versions in mise.toml and to regenerate the lock file.

_{Note: Security Review has been skipped due to the limited scope of the PR.}

[gemini-code-assist]

This auto-generated lock file contains invalid versions for the tools which will cause mise install to fail.

• golangci-lint version 2.11.3 (line 4) does not exist. The official releases are in the 1.x.y range (e.g., 1.59.1).
• go version 1.26.1 (line 43) does not exist. The latest stable Go version is 1.22.x.

The download URLs for these versions are invalid. This file should be regenerated by running mise lock after correcting the tool versions in mise.toml to point to valid, existing releases.

[gemini-code-assist]

Using latest for tool versions can lead to non-reproducible environments because the actual version can change over time. It is better to pin specific versions in this file.

Furthermore, latest appears to have resolved to invalid versions for both go (1.26.1) and golangci-lint (2.11.3), as seen in the mise.lock file. These versions do not exist, and their download URLs are invalid, which will cause mise install to fail.

Please pin to valid, existing versions. For go, you should use a version compatible with go 1.24 from your go.mod. For golangci-lint, you should use a valid release version (e.g., the latest is 1.59.1).

Suggested change

	go = "latest"
	"github:golangci/golangci-lint" = "latest"
	go = "1.24"
	"github:golangci/golangci-lint" = "1.59.1"