Skip to content

Add new vendor Dell#79

Merged
majst01 merged 46 commits intomasterfrom
dell-v2
Mar 2, 2026
Merged

Add new vendor Dell#79
majst01 merged 46 commits intomasterfrom
dell-v2

Conversation

@simcod
Copy link
Copy Markdown
Contributor

@simcod simcod commented Sep 19, 2025

Description

Add new vendor Dell

Comment thread internal/vendors/dell/dell.go Outdated
@izvyk
Copy link
Copy Markdown

izvyk commented Oct 13, 2025

There's still one problem I don't have a good solution for. After you set the boot order you have to reboot to apply changes. If you change your mind before the reboot it fails to set the values because of the pending request.

The first idea is to only apply the last change right before the reboot, which means in case of a failure it fails long time after it was set. And deferring the operation seems also quite complicated, no other function in the project requires this. So not a suitable good approach.

Another option is to create a job explicitly instead of issuing the boot order change request. And then delete the job in the job queue by its id (if you change your mind). That's better, but also not ideal.

Any thoughts on this? Do we have such a use case?

Comment thread internal/vendors/dell/dell.go Outdated
@simcod
Copy link
Copy Markdown
Contributor Author

simcod commented Oct 14, 2025

There's still one problem I don't have a good solution for. After you set the boot order you have to reboot to apply changes. If you change your mind before the reboot it fails to set the values because of the pending request.

The first idea is to only apply the last change right before the reboot, which means in case of a failure it fails long time after it was set. And deferring the operation seems also quite complicated, no other function in the project requires this. So not a suitable good approach.

Another option is to create a job explicitly instead of issuing the boot order change request. And then delete the job in the job queue by its id (if you change your mind). That's better, but also not ideal.

Any thoughts on this? Do we have such a use case?

How about triggering a reboot after the boot order was changed successfully?

@izvyk
Copy link
Copy Markdown

izvyk commented Oct 14, 2025

How about triggering a reboot after the boot order was changed successfully?

If reboot is no problem, I'll implement that now. Thank you!

@majst01
Copy link
Copy Markdown
Contributor

majst01 commented Oct 14, 2025

There's still one problem I don't have a good solution for. After you set the boot order you have to reboot to apply changes. If you change your mind before the reboot it fails to set the values because of the pending request.
The first idea is to only apply the last change right before the reboot, which means in case of a failure it fails long time after it was set. And deferring the operation seems also quite complicated, no other function in the project requires this. So not a suitable good approach.
Another option is to create a job explicitly instead of issuing the boot order change request. And then delete the job in the job queue by its id (if you change your mind). That's better, but also not ideal.
Any thoughts on this? Do we have such a use case?

How about triggering a reboot after the boot order was changed successfully?

This would lead to a massive delay during the installation process, not a good idea

Comment thread go.mod Outdated
@izvyk izvyk self-assigned this Oct 16, 2025
Comment thread internal/vendors/dell/dell.go Outdated
@Gerrit91 Gerrit91 moved this to In Progress in Development Jan 26, 2026
@majst01 majst01 marked this pull request as ready for review February 4, 2026 07:56
@majst01 majst01 requested a review from a team as a code owner February 4, 2026 07:56
@majst01 majst01 merged commit dba809a into master Mar 2, 2026
1 check passed
@majst01 majst01 deleted the dell-v2 branch March 2, 2026 08:51
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Development Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants