Add expand-realization-dimension test data#126
Merged
maxwhitemet merged 3 commits intometoppv:masterfrom Mar 25, 2026
Merged
Conversation
gavinevans
requested changes
Mar 12, 2026
Contributor
gavinevans
left a comment
gavinevans
left a comment
There was a problem hiding this comment.
Thanks @maxwhitemet 👍
I've added a comment.
Contributor
There was a problem hiding this comment.
It looks like the inputs here are just random numbers. It might demonstrate the functionality more easily if you use some actual data, and include some plots in the PR description, so that it is clear that the number of realizations has been increased, simply by repeating the realizations.
Contributor
Author
There was a problem hiding this comment.
Thanks @gavinevans. I have updated the test data and included some plots in the PR description.
gavinevans
approved these changes
Mar 12, 2026
mo-jbeaver
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance test data for the expand-realization-dimension CLI, addressing ticket #1010.
The below test data demonstrates the intended functionality, with a 2 realization cube extended to 3 realizations, with the 3rd realization repeating the 1st's data.
