Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
- Remove private npm packages from examples/cfgSync/package.json that are not publicly available (@microsoft/applicationinsights-rollup-plugin-uglify3-js and @microsoft/ai-test-framework) - Update examples/cfgSync/rollup.config.js to remove the uglify import and unused production build code that relied on the private package - Add cfgSync example link to examples/README.md - Enhance extensions/applicationinsights-cfgsync-js/README.md with Getting Started section, installation instructions, usage examples for all sync modes, and Plugin API reference table Agent-Logs-Url: https://github.com/microsoft/ApplicationInsights-JS/sessions/bdf4fd03-d85c-4946-9b0c-d93f9be312a2 Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
| "license": "MIT", | ||
| "sideEffects": false, | ||
| "devDependencies": { | ||
| "@microsoft/ai-test-framework": "0.0.1", |
There was a problem hiding this comment.
@copilot leave the build pipeline alone as there are downstream (non-visible) release pipelines that require these to exist
There was a problem hiding this comment.
Reverted in e944413 — package.json and rollup.config.js are restored to their original state.
| }) | ||
| } | ||
|
|
||
| const browserRollupConfigFactory = (name, isProduction, format = "umd", extension = "") => { |
There was a problem hiding this comment.
@copilot leave the build pipeline alone as there are downstream (non-visible) release pipelines that require these to exist
There was a problem hiding this comment.
Reverted in e944413 — both build pipeline files are restored to their original state.
…view feedback Agent-Logs-Url: https://github.com/microsoft/ApplicationInsights-JS/sessions/8e137937-3532-4db1-8985-19dfa2feba8c Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds getting-started documentation for the CfgSync plugin and links the new example from the examples index.
Changes:
- Added installation + usage docs (Broadcast, Receive, CDN fetch) and a Plugin API reference table to the CfgSync README
- Fixed documentation typos/wording in the CfgSync README
- Added CfgSync example link to the examples index
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| extensions/applicationinsights-cfgsync-js/README.md | Adds “Getting Started” guidance and an API reference section for CfgSync |
| examples/README.md | Adds CfgSync entry to the examples list |
| | Method | Description | | ||
| |--------|-------------| | ||
| | `getCfg()` | Returns the current configuration of this instance. | | ||
| | `setCfg(config)` | Manually sets the configuration of this instance. Returns `true` on success. | | ||
| | `sync(customDetails?)` | Manually broadcasts the current configuration to all listener instances. Returns `true` on success. | | ||
| | `pause()` | Pauses the scheduled CDN fetch timer. | | ||
| | `resume()` | Resumes the scheduled CDN fetch timer. | | ||
| | `updateEventListenerName(eventName?)` | Updates the custom event name used to broadcast/receive configuration changes. | |
There was a problem hiding this comment.
The Plugin API markdown table uses || at the start of each row, which GitHub Markdown interprets as an extra empty column (or can render incorrectly). Please switch this to standard table formatting (single leading pipe, or no leading/trailing pipes consistently), e.g. | Method | Description | with | --- | --- |.
| The CfgSync Plugin supports three synchronization modes: | ||
|
|
||
| - **Broadcast** (default): The instance broadcasts its configuration changes to other instances. | ||
| - **Receive**: The instance only receives configuration changes from broadcasting instances. | ||
| - **None**: The instance neither broadcasts nor receives configuration changes. |
There was a problem hiding this comment.
This section documents three modes including None, but the rest of the Getting Started examples only demonstrate Broadcast/Receive/CDN fetch. To avoid leaving readers without guidance, either add a short snippet showing how to configure syncMode: ICfgSyncMode.None, or remove the None bullet from this introductory list.
The CfgSync plugin lacked getting-started documentation.
Documentation
extensions/applicationinsights-cfgsync-js/README.md: Added "Getting Started" section with install instructions, usage examples for all three sync modes (Broadcast,Receive, CDN fetch), and a Plugin API method reference table. Fixed typo ("mutiple" → "multiple").examples/README.md: Added CfgSync example to the examples index.Example: Broadcast + Receive setup (now documented)