[main] Update BCArtifact version. New value: 29.0.47702.0#7178
Closed
business-central-bot[bot] wants to merge 1 commit intomainfrom
Closed
[main] Update BCArtifact version. New value: 29.0.47702.0#7178business-central-bot[bot] wants to merge 1 commit intomainfrom
business-central-bot[bot] wants to merge 1 commit intomainfrom
Conversation
business-central-bot
bot
added
the
Automation
github-actions
bot
added
the
Build: Automation
aholstrup1
approved these changes
Mar 17, 2026
mazhelez
approved these changes
Mar 17, 2026
auto-merge was automatically disabled
March 18, 2026 07:49
Pull request was closed
Groenbech96
added a commit
that referenced
this pull request
Mar 18, 2026
## Summary Fix E-Document premature `Commit()` during Inventory Pick posting that causes data inconsistency (Bug 625438). ### Problem When an Inventory Pick posts with an E-Document Service Flow configured, the E-Document export path executes an unconditional `Commit()` inside `OnAfterPostSalesDoc`. This commits the Sales Shipment and ILE before warehouse entries are created, causing an inventory-to-warehouse ledger mismatch if the warehouse bin check later fails. ### Solution - Add `AllowCreateEDocument` guard to `OnAfterPostSalesDoc`, `OnAfterTransferOrderPostShipment`, and `OnAfterPostServiceDoc` subscribers to skip E-Document creation during Inventory Pick flows (when `InvtPickPutaway`, `CommitIsSuppressed`, or `PreviewMode` is set) - Subscribe to the new `OnAfterPostWhseActivityCompleted` event for deferred E-Document creation — this event fires after all posting work completes (including `PostRelatedInboundTransfer`), so the full transaction is already persisted - Migrate Subcontracting subscriber from obsoleted `OnAfterPostWhseActivHeader` to `OnAfterPostWhseActivityCompleted` **NAV dependency:** NAV master PR [242528](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_git/NAV/pullrequest/242528) (obsoletes `OnAfterPostWhseActivHeader`, adds `OnAfterPostWhseActivityCompleted`) [AB#625588](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/625588) Fixes #7178 --------- Co-authored-by: Magnus Hartvig Grønbech <magnushar@microsoft.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: mazhelez <mazhelez@users.noreply.github.com>
Groenbech96
added a commit
that referenced
this pull request
Mar 18, 2026
Fix E-Document premature `Commit()` during Inventory Pick posting that causes data inconsistency (Bug 625438). When an Inventory Pick posts with an E-Document Service Flow configured, the E-Document export path executes an unconditional `Commit()` inside `OnAfterPostSalesDoc`. This commits the Sales Shipment and ILE before warehouse entries are created, causing an inventory-to-warehouse ledger mismatch if the warehouse bin check later fails. - Add `AllowCreateEDocument` guard to `OnAfterPostSalesDoc`, `OnAfterTransferOrderPostShipment`, and `OnAfterPostServiceDoc` subscribers to skip E-Document creation during Inventory Pick flows (when `InvtPickPutaway`, `CommitIsSuppressed`, or `PreviewMode` is set) - Subscribe to the new `OnAfterPostWhseActivityCompleted` event for deferred E-Document creation — this event fires after all posting work completes (including `PostRelatedInboundTransfer`), so the full transaction is already persisted - Migrate Subcontracting subscriber from obsoleted `OnAfterPostWhseActivHeader` to `OnAfterPostWhseActivityCompleted` **NAV dependency:** NAV master PR [242528](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_git/NAV/pullrequest/242528) (obsoletes `OnAfterPostWhseActivHeader`, adds `OnAfterPostWhseActivityCompleted`) [AB#625588](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/625588) Fixes #7178 --------- Co-authored-by: Magnus Hartvig Grønbech <magnushar@microsoft.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: mazhelez <mazhelez@users.noreply.github.com>
Groenbech96
added a commit
that referenced
this pull request
Mar 19, 2026
Fix E-Document premature `Commit()` during Inventory Pick posting that causes data inconsistency (Bug 625438). When an Inventory Pick posts with an E-Document Service Flow configured, the E-Document export path executes an unconditional `Commit()` inside `OnAfterPostSalesDoc`. This commits the Sales Shipment and ILE before warehouse entries are created, causing an inventory-to-warehouse ledger mismatch if the warehouse bin check later fails. - Add `AllowCreateEDocument` guard to `OnAfterPostSalesDoc`, `OnAfterTransferOrderPostShipment`, and `OnAfterPostServiceDoc` subscribers to skip E-Document creation during Inventory Pick flows (when `InvtPickPutaway`, `CommitIsSuppressed`, or `PreviewMode` is set) - Subscribe to the new `OnAfterPostWhseActivityCompleted` event for deferred E-Document creation — this event fires after all posting work completes (including `PostRelatedInboundTransfer`), so the full transaction is already persisted - Migrate Subcontracting subscriber from obsoleted `OnAfterPostWhseActivHeader` to `OnAfterPostWhseActivityCompleted` **NAV dependency:** NAV master PR [242528](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_git/NAV/pullrequest/242528) (obsoletes `OnAfterPostWhseActivHeader`, adds `OnAfterPostWhseActivityCompleted`) [AB#625588](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/625588) Fixes #7178 --------- Co-authored-by: Magnus Hartvig Grønbech <magnushar@microsoft.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: mazhelez <mazhelez@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
AB#539394