Pack cswinrt.exe under tools\win-x86 in the NuGet package#2344
Merged
manodasanW merged 4 commits intostaging/3.0from Mar 18, 2026
Merged
Pack cswinrt.exe under tools\win-x86 in the NuGet package#2344manodasanW merged 4 commits intostaging/3.0from
manodasanW merged 4 commits intostaging/3.0from
Conversation
Update the nuspec to place cswinrt.exe under the tools\win-x86 directory instead of the package root, consistent with how other architecture-specific tools (cswinrtinteropgen, cswinrtimplgen, cswinrtprojectiongen) are already organized. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Update the MSBuild property that resolves the cswinrt.exe path to reflect its new location under tools\win-x86 in the NuGet package. All targets and tasks reference this property, so no other changes are needed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the Microsoft.Windows.CsWinRT NuGet package layout so cswinrt.exe is placed under an architecture-specific tools folder (tools\win-x86) and updates the MSBuild property that locates the executable accordingly.
Changes:
- Pack
cswinrt.exeintotools\win-x86in the.nuspecinstead of the package root. - Update
CsWinRTExein the.propsfile to point to$(CsWinRTPath)tools\win-x86\cswinrt.exe.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| nuget/Microsoft.Windows.CsWinRT.props | Updates CsWinRTExe to resolve to the new tools\win-x86 location. |
| nuget/Microsoft.Windows.CsWinRT.nuspec | Packs cswinrt.exe under tools\win-x86 to match the desired package structure. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Make CsWinRTExe conditional in the NuGet props so it does not override the value set by internal builds. Set CsWinRTExe explicitly in src\Directory.Build.props to point directly at cswinrt.exe within the local build output directory. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
manodasanW
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves
cswinrt.exefrom the root of the NuGet package to thetools\win-x86subdirectory, consistent with how other architecture-specific tools (cswinrtinteropgen,cswinrtimplgen,cswinrtprojectiongen) are already organized.Changes
nuget\Microsoft.Windows.CsWinRT.nuspec: Addedtarget="tools\win-x86"to thecswinrt.exefile entry so it is packed under thetools\win-x86directory instead of the package root.nuget\Microsoft.Windows.CsWinRT.props: Updated theCsWinRTExeMSBuild property to resolve to$(CsWinRTPath)tools\win-x86\cswinrt.exe, matching the new package layout.All targets and tasks (
Microsoft.Windows.CsWinRT.targets,Microsoft.Windows.CsWinRT.CsWinRTGen.targets,RunCsWinRTMergedProjectionGenerator) reference the$(CsWinRTExe)property from the props file, so no other changes are needed.