Add missing diagnostic message for private method quick fix#63144
Open
drtootsie wants to merge 1 commit intomicrosoft:mainfrom
Open
Add missing diagnostic message for private method quick fix#63144drtootsie wants to merge 1 commit intomicrosoft:mainfrom
drtootsie wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Fixes microsoft#37782 The code fix logic for adding missing private methods already existed in fixAddMissingMember.ts (code 90038), but the diagnostic message was missing from diagnosticMessages.json. Added 'Declare private method {0}' message with code 90038 to enable the quick fix to appear in the IDE.
typescript-bot
added
the
For Uncommitted Bug
Member
|
I'm not sure how this would work, our diagnostics generate code which we then reference, if this were all that was needed, the code would not be compiling today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37782
Summary
The code fix logic for adding missing private methods already existed (code 90038), but the diagnostic message was missing from
diagnosticMessages.json.Changes
Added the diagnostic message
"Declare private method '{0}'"with code 90038 to enable the quick fix to appear in the IDE.Testing
The fix can be verified by:
npm install && npm run build