samples: sync NotesApp with latest ACI API changes#606
Draft
surajkumar-08 wants to merge 2 commits intomicrosoft:release/experimentalfrom
Draft
samples: sync NotesApp with latest ACI API changes#606surajkumar-08 wants to merge 2 commits intomicrosoft:release/experimentalfrom
surajkumar-08 wants to merge 2 commits intomicrosoft:release/experimentalfrom
Conversation
- Update namespace from Microsoft.Windows.AI.Search.Experimental.AppContentIndex to Microsoft.Windows.Search.AppContentIndex - Rename Remove -> RemoveContentItem, RemoveAll -> RemoveAllContentItems - Rename Subregion -> RegionOfInterest on image query matches - Update WinAppSDK from 2.0.0-experimental3 to 2.0.0-preview1 - Add IDisposable to SearchViewModel for proper cleanup - Remove stale commented-out internal project references from csproj - Fix README: correct solution filename, update SDK version reference - Clean up Package.appxmanifest identity for public sample Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
@surajkumar-08 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Syncs AppContentSearch/NotesApp sample with upstream
aifabric repo changes for Windows App SDK
2.0.0-preview1.
What changed (9 files)
API migration
Microsoft.Windows.AI.Search.Experimental.AppContentIndex→
Microsoft.Windows.Search.AppContentIndexRemove()→RemoveContentItem()RemoveAll()→RemoveAllContentItems()Subregion→RegionOfInterestPackage updates
2.0.0-experimental3→2.0.0-preview1Code quality
IDisposableimplementation onSearchViewModelCA2000pragmas for bitmap lifecycle insnippet code
InvalidOperationExceptionfor error handlingProject cleanup
references
AIFabricTestidentityto
AppContentSearchSampleDocumentation
.slnfilename, line-wrapped prose at 80 charsTarget Release
Please specify which release this PR should align with. e.g., 1.0, 1.1, 1.1 Preview 1.
Checklist
Note that /azp run currently isn't working for this repo.