Update memory leak test to include add_listener#57
Open
bghgary wants to merge 1 commit intomicrosoft:masterfrom
Open
Update memory leak test to include add_listener#57bghgary wants to merge 1 commit intomicrosoft:masterfrom
bghgary wants to merge 1 commit intomicrosoft:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the existing memory leak test for cancellation::none() by adding explicit coverage of the add_listener method. The test verifies that calling add_listener on the none() singleton (which is backed by a no_destroy wrapper) does not trigger any heap allocations that would be reported as leaks.
Changes:
- Added test code to exercise the
add_listenerearly-out path oncancellation::none() - Updated comments to document the additional test coverage
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ryantrem
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.