This repository was archived by the owner on Feb 15, 2022. It is now read-only.
Mentioning a common pitfall in the tutorial#641
Open
CannibalKush wants to merge 1 commit intomicrosoft:masterfrom
Open
Mentioning a common pitfall in the tutorial#641CannibalKush wants to merge 1 commit intomicrosoft:masterfrom
CannibalKush wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Contributor
Author
|
It would also make sense to remove the step from the preceding tutorial to set FAB_ENVS, as the build script will automatically set the env to 'prod' as it is done in the tutorial. There would be functionally no difference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since a user can reasonably be expected to land on this tutorial immediately following the one regarding the manifest generation pipeline, it seems like a good idea to mention this pitfall.