Add ruby support via solargraph#46
Conversation
|
@microsoft-github-policy-service agree company="Def Method" |
|
Dear @sbrudz Thanks for the amazing PR! Could you please have a look at the following error being thrown in the automated ruby tests (https://github.com/microsoft/multilspy/actions/runs/12918692497/job/36099508872?pr=46#step:5:205)? Can we try to make it so that it works gracefully across versions? Please let me know your bandwidth and availability, and thanks a lot for your contribution! Once this issue is addressed, I will be able to merge the PR. |
d6f3a0d to
1b934d3
Compare
|
Thanks for reviewing! I've removed the part of the code that checked the I tested this on another repo locally and solargraph was able to handle indexing older ruby code while running via a newer ruby version without any issues. |
|
I'll take a look at the test failure in commit 1b934d3. |
This is excellent. Please have a look at #39 , and let's discuss there the appropriate way to support multiple programming language <> multiple LSPs. |
|
The tests should all be passing now. Let me know if you'd like me to squash some of the commits to clean things up. I'll take a look at #39 tomorrow. |
This PR adds support for the ruby language by adding the solargraph LSP server.
We're also interested in adding ruby-lsp as an alternative server in a future PR. Not sure of the preferred way to support multiple LSP servers for the same language, though. If you have any recommendations, please let me know.