Conversation
|
@microsoft-github-policy-service agree company="Cisco Systems, Inc." |
| """ | ||
| # Create a basic initialize params structure | ||
| # This can be expanded with more specific settings if needed | ||
| params = { |
There was a problem hiding this comment.
Could you write this configuration to a separate json file in the same directory, and read from there?
There was a problem hiding this comment.
See other language server implementations for example
| assert isinstance(result, list) | ||
| # The exact assertions will depend on the actual response from the Perl Language Server | ||
| # These are placeholder assertions that should be updated with actual expected values | ||
| assert len(result) >= 0 |
There was a problem hiding this comment.
Can you please add actual expected values instead of placeholders?
|
|
||
| assert isinstance(result, list) | ||
| # The exact assertions will depend on the actual response from the Perl Language Server | ||
| # These are placeholder assertions that should be updated with actual expected values |
|
Thanks a lot for your PR! Could you also add an entry in the README about PERL support? |
|
I also see that the unit test is failing, likely cause is that perl is not available in the test environment. My intention with multilspy is for it to be batteries-included - any new language support should ideally handle the downloading+setup of the lsp binary, unless it is not feasible in the scope of multilspy to do so. Could you please try to implement the setup_runtime_dependencies method in the perl language server class? If not feasible, the other option would be to add Perl to the github action/CI config. |
2 participants
No description provided.