Update models and address auto import of agents#35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactorings related to language model (LLM) handling, agent registration, and token counting. The main focus is on making model handling more robust and maintainable by centralizing model lists, improving logic for model-specific parameters, enhancing token counting, and refining agent registration checks.
Model Handling Improvements:
agents/llm.pyandagents/reasoning.py, replacing scattered hard-coded lists with shared variables for easier maintenance and consistency. Logic throughout the agents now uses these lists to determine model-specific parameter handling. [1] [2] [3] [4] [5] [6]Token Counting and Model Support:
tales/token.pyto include new variants (gpt-5.1,gpt-5.2) and improved the token counting logic to handle boilerplate tokens more accurately. Also, Gemini token counter now strips thegemini/prefix if present. [1] [2]Agent Registration Robustness:
registerfunction intales/agent.pyto check for duplicate agent registration more accurately by comparing class names, preventing accidental overwrites or misleading errors. [1] [2]Benchmarking and Logging: