Skip to content

Fix ItemWithPath throwing on null/empty/whitespace path instead of generating malformed URLs #3072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix ItemWithPath throwing on null/empty/whitespace path instead of generating malformed URLs #3072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57a54a0
Initial plan
Copilot Mar 9, 2026
4d05856
Fix ItemWithPath to throw on null/empty/whitespace path
Copilot Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions src/Microsoft.Graph/Extensions/DriveItemRequestBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,14 @@ public static class DriveItemRequestBuilderExtensions
/// </summary>
public static CustomDriveItemItemRequestBuilder ItemWithPath(this Microsoft.Graph.Drives.Item.Root.RootRequestBuilder rootRequestBuilder, string path)
{
if (!string.IsNullOrEmpty(path))
if (path is null)
throw new ArgumentNullException(nameof(path));
if (string.IsNullOrWhiteSpace(path))
throw new ArgumentException("path cannot be empty or whitespace.", nameof(path));

if (!path.StartsWith("/"))
{
if (!path.StartsWith("/"))
{
path = string.Format("/{0}", path);
}
path = string.Format("/{0}", path);
}

var requestInformation = rootRequestBuilder.ToGetRequestInformation();
Expand All @@ -67,12 +69,14 @@ public static CustomDriveItemItemRequestBuilder ItemWithPath(this Microsoft.Grap
/// </summary>
public static CustomDriveItemItemRequestBuilder ItemWithPath(this Microsoft.Graph.Drives.Item.Items.Item.DriveItemItemRequestBuilder rootRequestBuilder, string path)
{
if (!string.IsNullOrEmpty(path))
if (path is null)
throw new ArgumentNullException(nameof(path));
if (string.IsNullOrWhiteSpace(path))
throw new ArgumentException("path cannot be empty or whitespace.", nameof(path));

if (!path.StartsWith("/"))
{
if (!path.StartsWith("/"))
{
path = string.Format("/{0}", path);
}
path = string.Format("/{0}", path);
}

var requestInformation = rootRequestBuilder.ToGetRequestInformation();
Expand Down
32 changes: 32 additions & 0 deletions ...osoft.Graph.DotnetCore.Test/Requests/Extensions/DriveItemRequestBuilderExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,5 +141,37 @@ public void ItemByPath_BuildRequestWithNestedPathSlashAndMoreThanOneParameter()
Assert.NotNull(itemRequestInformation);
Assert.Equal(expectedRequestUri, itemRequestInformation.URI);
}
[Fact]
public void ItemByPath_ThrowsArgumentNullException_WhenPathIsNull_Root()
{
var graphServiceClient = new GraphServiceClient(new MockAuthenticationProvider().Object);
Assert.Throws<ArgumentNullException>(() => graphServiceClient.Drives["driveId"].Root.ItemWithPath(null));
}

[Theory]
[InlineData("")]
[InlineData(" ")]
public void ItemByPath_ThrowsArgumentException_WhenPathIsEmptyOrWhitespace_Root(string path)
{
var graphServiceClient = new GraphServiceClient(new MockAuthenticationProvider().Object);
Assert.Throws<ArgumentException>(() => graphServiceClient.Drives["driveId"].Root.ItemWithPath(path));
}

[Fact]
public void ItemByPath_ThrowsArgumentNullException_WhenPathIsNull_DriveItem()
{
var graphServiceClient = new GraphServiceClient(new MockAuthenticationProvider().Object);
Assert.Throws<ArgumentNullException>(() => graphServiceClient.Drives["driveId"].Items["itemId"].ItemWithPath(null));
}

[Theory]
[InlineData("")]
[InlineData(" ")]
public void ItemByPath_ThrowsArgumentException_WhenPathIsEmptyOrWhitespace_DriveItem(string path)
{
var graphServiceClient = new GraphServiceClient(new MockAuthenticationProvider().Object);
Assert.Throws<ArgumentException>(() => graphServiceClient.Drives["driveId"].Items["itemId"].ItemWithPath(path));
}

}
}