Enable EnablePackageValidation for all src packages with 0.9.0-preview.1 baseline#1330
Draft
Enable EnablePackageValidation for all src packages with 0.9.0-preview.1 baseline#1330
EnablePackageValidation for all src packages with 0.9.0-preview.1 baseline#1330Conversation
…src packages Co-authored-by: jeffhandley <1031940+jeffhandley@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add package validation to catch breaking changes
Enable Feb 20, 2026
EnablePackageValidation for all src packages with 0.9.0-preview.1 baseline
jeffhandley
approved these changes
Feb 20, 2026
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0002</DiagnosticId> | ||
| <Target>M:ModelContextProtocol.Protocol.ListTasksResult.get_Tasks</Target> |
Member
There was a problem hiding this comment.
Is this adding suppressions for experimental APIs presumably?
| <EmbedUntrackedSources>true</EmbedUntrackedSources> | ||
| <AssemblyOriginatorKeyFile>$(RepoRoot)\Open.snk</AssemblyOriginatorKeyFile> | ||
| <SignAssembly>true</SignAssembly> | ||
| <EnablePackageValidation>true</EnablePackageValidation> |
Member
There was a problem hiding this comment.
Maybe we can keep this turned off until we have a final stable release.
Suggested change
| <EnablePackageValidation>true</EnablePackageValidation> | |
| <EnablePackageValidation>false</EnablePackageValidation> |
eiriktsarpalis
approved these changes
Feb 20, 2026
stephentoub
reviewed
Feb 20, 2026
| <Target>M:ModelContextProtocol.Authentication.DynamicClientRegistrationResponse.get_GrantTypes</Target> | ||
| <Left>lib/net10.0/ModelContextProtocol.Core.dll</Left> | ||
| <Right>lib/net10.0/ModelContextProtocol.Core.dll</Right> | ||
| <IsBaselineSuppression>true</IsBaselineSuppression> |
Contributor
There was a problem hiding this comment.
Why do we need any suppressions right now?
Collaborator
There was a problem hiding this comment.
Because we've already made changes in main; and this caught them. But I'll wait to finalize this PR until we cut 1.0.0 stable, and clear the suppressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opts into
EnablePackageValidationso the build catches API breaking changes automatically against the published0.9.0-preview.1baseline.Changes
src/Directory.Build.props: AddsEnablePackageValidation=trueandPackageValidationBaselineVersion=0.9.0-preview.1— applies to all three packable projects (ModelContextProtocol.Core,ModelContextProtocol,ModelContextProtocol.AspNetCore)src/ModelContextProtocol.Core/CompatibilitySuppressions.xml: Suppresses intentional breaking changes already made post-0.9.0-preview.1(property type changes onProtectedResourceMetadata,DynamicClientRegistrationResponse,ToolResultContentBlock.Content, andListTasksResult.Tasks). All suppressions are markedIsBaselineSuppression=true.Any new breaking change introduced going forward will fail
dotnet packunless explicitly suppressed.Original prompt
EnablePackageValidationto catch breaking changes #1329💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.