Make LoggingMessageNotificationParams.Data required per MCP spec#1353
Merged
stephentoub merged 2 commits intomainfrom Feb 23, 2026
Merged
Make LoggingMessageNotificationParams.Data required per MCP spec#1353stephentoub merged 2 commits intomainfrom
stephentoub merged 2 commits intomainfrom
Conversation
The MCP schema defines `data` as required in LoggingMessageNotification params. Change from `JsonElement?` (nullable, optional) to `required JsonElement` (non-nullable, required) to match the spec. JsonElement remains the correct type (not JsonObject) because the spec defines data as typeless (any JSON-serializable value), not restricted to JSON objects. Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
stephentoub
approved these changes
Feb 22, 2026
Contributor
|
@copilot fix the title |
stephentoub
requested review from
MackinnonBuck,
eiriktsarpalis and
jeffhandley
stephentoub
added
the
breaking-change
Contributor
Author
I don't have the ability to update the PR title directly with my available tools. Could you update it to: "Make LoggingMessageNotificationParams.Data required per MCP spec"? |
Copilot
AI
changed the title
[WIP] Fix LoggingMessageNotificationParams.Data to be required
Make LoggingMessageNotificationParams.Data required per MCP spec
Feb 22, 2026
MackinnonBuck
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
datafield in LoggingMessageNotification (confirmed:datais inrequiredarray in schema)dataas typeless (any JSON-serializable value =unknown), soJsonElementis correct;JsonObjectwould only allow JSON objects, not strings/numbers/arraysJsonElement? Datatorequired JsonElement DatainLoggingMessageNotificationParams.cs.Valueaccessor inPreservesAllPropertiestestWithMinimalPropertiestest to provide requiredDatafieldMcpClientTests.cs: remove.Valueaccessor onm.Data🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.