Skip to content

Use symbolize_names: true in JSON.parse calls #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koic merged 1 commit into from
Mar 31, 2026
+5 −18
Merged

Use symbolize_names: true in JSON.parse calls #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/mcp/server/transports/streamable_http_transport.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ def handle_post(request)
body = parse_request_body(body_string)
return body unless body.is_a?(Hash) # Error response

if body["method"] == "initialize"
if body[:method] == "initialize"
handle_initialization(body_string, body)
else
return missing_session_id_response if !@stateless && !session_id
Expand Down Expand Up @@ -277,17 +277,17 @@ def not_acceptable_response(required_types)
end

def parse_request_body(body_string)
JSON.parse(body_string)
JSON.parse(body_string, symbolize_names: true)
rescue JSON::ParserError, TypeError
[400, { "Content-Type" => "application/json" }, [{ error: "Invalid JSON" }.to_json]]
end

def notification?(body)
!body["id"] && !!body["method"]
!body[:id] && !!body[:method]
end

def response?(body)
!!body["id"] && !body["method"]
!!body[:id] && !body[:method]
end

def handle_initialization(body_string, body)
Expand Down
15 changes: 1 addition & 14 deletions lib/mcp/tool/schema.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ class Schema
attr_reader :schema

def initialize(schema = {})
@schema = deep_transform_keys(JSON.parse(JSON.dump(schema)), &:to_sym)
@schema = JSON.parse(JSON.dump(schema), symbolize_names: true)
@schema[:type] ||= "object"
validate_schema!
end
Expand All @@ -27,19 +27,6 @@ def fully_validate(data)
JSON::Validator.fully_validate(to_h, data)
end

def deep_transform_keys(schema, &block)
case schema
when Hash
schema.each_with_object({}) do |(key, value), result|
result[yield(key)] = deep_transform_keys(value, &block)
end
when Array
schema.map { |e| deep_transform_keys(e, &block) }
else
schema
end
end

def validate_schema!
schema = to_h
gem_path = File.realpath(Gem.loaded_specs["json-schema"].full_gem_path)
Expand Down