Join server threads before closing IO pipes in stdio client tests#280
Open
koic wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Join server threads before closing IO pipes in stdio client tests#280koic wants to merge 1 commit intomodelcontextprotocol:mainfrom
koic wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Background threads simulating server responses could race with the `ensure` block that closes IO pipes, intermittently producing this warning depending on thread scheduling: ```console #<Thread:0x00007fb69290cbd0 test/mcp/client/stdio_test.rb:28 run> terminated with exception (report_on_exception is true): test/mcp/client/stdio_test.rb:55:in `write': stream closed in another thread (IOError) ``` Store each background thread in a `server_thread` variable and call `server_thread&.join(1)` at the top of each `ensure` block to wait for the thread to finish before closing pipes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Background threads simulating server responses could race with the
ensureblock that closes IO pipes, intermittently producing this warning depending on thread scheduling:Store each background thread in a
server_threadvariable and callserver_thread&.join(1)at the top of eachensureblock to wait for the thread to finish before closing pipes.How Has This Been Tested?
This verifies that no race condition occurs.
Breaking Changes
None. This change updates only the test code.
Types of changes
Checklist