Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
* The `MetricsHandler` interface now requires two additional methods: `record_database_load()` and `record_database_migration()`
* In Kotlin expose `GleanMetrics.Pings.nimbusTargetingContext` as `Nimbus.Pings.nimbusTargetingContext` for downstream tests. ([#14542](https://github.com/mozilla/experimenter/issues/14542))

### Remote-Settings
* Removed old remote-settings client code that is no longer used.
* Renaming `RemoteSettingsConfig2` to `RemoteSettingsConfig`, which will require client updates.

[Full Changelog](In progress)

# v149.0 (_2026-02-23_)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ package org.mozilla.experiments.nimbus
import android.content.Context
import androidx.test.core.app.ApplicationProvider
import kotlinx.coroutines.Job
import mozilla.appservices.remotesettings.RemoteSettingsConfig2
import mozilla.appservices.remotesettings.RemoteSettingsConfig
import mozilla.appservices.remotesettings.RemoteSettingsService
import org.junit.Assert.assertEquals
import org.junit.Assert.assertFalse
Expand Down Expand Up @@ -35,7 +35,7 @@ class NimbusBuilderTest {
}.build(
appInfo,
NimbusServerSettings(
rsService = RemoteSettingsService(storageDir = "dummy", config = RemoteSettingsConfig2()),
rsService = RemoteSettingsService(storageDir = "dummy", config = RemoteSettingsConfig()),
collectionName = "nimbus-preview",
),
) as DummyNimbus
Expand Down
7 changes: 4 additions & 3 deletions components/nimbus/tests/common.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#![cfg(feature = "rkv-safe-mode")]

use remote_settings::{RemoteSettingsConfig, RemoteSettingsContext, RemoteSettingsService};
use rkv::StoreOptions;

// utilities shared between tests

use nimbus::error::{Result, debug};
Expand All @@ -13,8 +16,6 @@ use nimbus::metrics::{
use nimbus::stateful::client::NimbusServerSettings;
use nimbus::stateful::persistence::{Database, SingleStore};
use nimbus::{AppContext, NimbusClient, RemoteSettingsServer};
use remote_settings::{RemoteSettingsConfig2, RemoteSettingsContext, RemoteSettingsService};
use rkv::StoreOptions;
use std::{path::Path, sync::Arc};

pub struct NoopMetricsHandler;
Expand Down Expand Up @@ -93,7 +94,7 @@ fn new_test_client_internal(
..Default::default()
};

let config = RemoteSettingsConfig2 {
let config = RemoteSettingsConfig {
server: Some(RemoteSettingsServer::Custom {
url: url.as_str().to_string(),
}),
Expand Down
5 changes: 2 additions & 3 deletions components/nimbus/tests/test_fs_client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,12 @@ mod common;

use std::path::PathBuf;
use std::sync::Arc;

use url::Url;

use nimbus::error::Result;
use nimbus::stateful::client::NimbusServerSettings;
use nimbus::{NimbusClient, RemoteSettingsServer};
use remote_settings::{RemoteSettingsConfig2, RemoteSettingsContext, RemoteSettingsService};
use remote_settings::{RemoteSettingsConfig, RemoteSettingsContext, RemoteSettingsService};

use crate::common::NoopMetricsHandler;

Expand All @@ -30,7 +29,7 @@ fn test_simple() -> Result<()> {

let url = Url::from_file_path(dir).expect("experiments dir should exist");

let config = RemoteSettingsConfig2 {
let config = RemoteSettingsConfig {
server: Some(RemoteSettingsServer::Custom {
url: url.as_str().to_string(),
}),
Expand Down
4 changes: 2 additions & 2 deletions components/relay/src/rs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -298,11 +298,11 @@ impl RelayRemoteSettingsClient {
#[cfg(test)]
mod tests {
use super::*;
use remote_settings::{RemoteSettingsConfig2, RemoteSettingsServer};
use remote_settings::{RemoteSettingsConfig, RemoteSettingsServer};

// Helper to create a RemoteSettingsService for testing
fn create_test_remote_settings_service() -> Arc<RemoteSettingsService> {
let config = RemoteSettingsConfig2 {
let config = RemoteSettingsConfig {
server: Some(RemoteSettingsServer::Custom {
url: "http://localhost".to_string(),
}),
Expand Down

This file was deleted.

This file was deleted.

Loading