Bug2007406 - Add server knobs config to ping_info#3396
Merged
travis79 merged 4 commits intomozilla:mainfrom Apr 2, 2026
Merged
Bug2007406 - Add server knobs config to ping_info#3396travis79 merged 4 commits intomozilla:mainfrom
travis79 merged 4 commits intomozilla:mainfrom
Conversation
badboy
reviewed
Feb 10, 2026
travis79
temporarily deployed
to
pull_request
GitHub Actions
Inactive
travis79
temporarily deployed
to
pull_request
GitHub Actions
Inactive
travis79
temporarily deployed
to
pull_request
GitHub Actions
Inactive
travis79
temporarily deployed
to
pull_request
GitHub Actions
Inactive
chutten
requested changes
Feb 18, 2026
docs/user/user/server-knobs/metrics/experimenter-configuration.md
Outdated
Show resolved
Hide resolved
docs/user/user/server-knobs/pings/experimenter-configuration.md
Outdated
Show resolved
Hide resolved
docs/user/user/server-knobs/pings/experimenter-configuration.md
Outdated
Show resolved
Hide resolved
docs/user/user/server-knobs/pings/experimenter-configuration.md
Outdated
Show resolved
Hide resolved
This adds the currently applied server knobs config to all pings in the ping_info section, or omits it if no server knobs config is applied. This should help to calculate effective sampling rates for metrics and pings that are being sampled in the client.
travis79
force-pushed
the
Bug2007406
branch
3 times, most recently
from
35696d1 to
f1f634c
Compare
- Remove clone() by serializing directly from MutexGuard ref - Add safety comments for all unwrap() calls - Skip serializing empty maps and null event_threshold to reduce ping size - Extract shared docs into an include file to avoid duplication - Fix metric category in docs to glean.internal.metrics - Add "except metadata.include_info_sections: false" qualifier to docs - Change test event_threshold to non-default value (41) - Add test verifying empty fields are omitted from serialized config - Remove accidentally committed uv.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the currently applied server knobs config to all pings in the ping_info section, or omits it if no server knobs config is applied. This should help to calculate effective sampling rates for metrics and pings that are being sampled in the client.
Schema update PR is here: mozilla-services/mozilla-pipeline-schemas#857