Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

* Rust
* Add support for determining `client_info.os_version` for Android binaries ([#3434](https://github.com/mozilla/glean/pull/3434))
* `client_info.os_version` can now be set by the application. If unset Glean still uses the auto-detection ([#3419](https://github.com/mozilla/glean/pull/3419))

# v67.2.0 (2026-04-06)

Expand Down
1 change: 1 addition & 0 deletions docs/user/reference/general/initializing.md
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ let client_info = ClientInfoMetrics {
app_display_version: env!("CARGO_PKG_VERSION").to_string(),
channel: None,
locale: None,
os_version: None, // auto-detected
};

glean::initialize(cfg, client_info);
Expand Down
1 change: 1 addition & 0 deletions glean-core/rlb-tests/src/bin/crashing-threads.rs
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ fn main() {
app_display_version: env!("CARGO_PKG_VERSION").to_string(),
channel: None,
locale: None,
os_version: None,
};

glean::initialize(cfg, client_info);
Expand Down
1 change: 1 addition & 0 deletions glean-core/rlb-tests/src/bin/delayed-ping-data.rs
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ fn main() {
app_display_version: env!("CARGO_PKG_VERSION").to_string(),
channel: None,
locale: None,
os_version: None,
};

glean::initialize(cfg, client_info);
Expand Down
1 change: 1 addition & 0 deletions glean-core/rlb-tests/src/bin/enabled-pings.rs
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ fn main() {
app_display_version: env!("CARGO_PKG_VERSION").to_string(),
channel: None,
locale: None,
os_version: None,
};

glean::initialize(cfg, client_info);
Expand Down
1 change: 1 addition & 0 deletions glean-core/rlb-tests/src/bin/long-running.rs
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ fn main() {
app_display_version: env!("CARGO_PKG_VERSION").to_string(),
channel: None,
locale: None,
os_version: None,
};

glean::initialize(cfg, client_info);
Expand Down
1 change: 1 addition & 0 deletions glean-core/rlb-tests/src/bin/mps-delay.rs
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ fn main() {
app_display_version: env!("CARGO_PKG_VERSION").to_string(),
channel: None,
locale: None,
os_version: None,
};

glean::initialize(cfg, client_info);
Expand Down
1 change: 1 addition & 0 deletions glean-core/rlb-tests/src/bin/pending-gets-removed.rs
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ fn main() {
app_display_version: env!("CARGO_PKG_VERSION").to_string(),
channel: None,
locale: None,
os_version: None,
};

// Ensure this ping is always registered early.
Expand Down
1 change: 1 addition & 0 deletions glean-core/rlb-tests/src/bin/ping-lifetime-flush.rs
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ fn main() {
app_display_version: env!("CARGO_PKG_VERSION").to_string(),
channel: None,
locale: None,
os_version: None,
};

glean::initialize(cfg, client_info);
Expand Down
1 change: 1 addition & 0 deletions glean-core/rlb/examples/frequent-events.rs
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ fn main() {
app_display_version: env!("CARGO_PKG_VERSION").to_string(),
channel: None,
locale: None,
os_version: None,
};

glean::initialize(cfg, client_info);
Expand Down
1 change: 1 addition & 0 deletions glean-core/rlb/examples/prototype.rs
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ fn main() {
app_display_version: env!("CARGO_PKG_VERSION").to_string(),
channel: None,
locale: None,
os_version: None,
};

glean::initialize(cfg, client_info);
Expand Down
5 changes: 4 additions & 1 deletion glean-core/rlb/src/core_metrics.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ pub struct ClientInfoMetrics {
pub channel: Option<String>,
/// The locale of the application during initialization (e.g. "es-ES").
pub locale: Option<String>,
/// The user-visible version of the operating system (e.g. "1.2.3").
pub os_version: Option<String>,
}

impl ClientInfoMetrics {
Expand All @@ -25,6 +27,7 @@ impl ClientInfoMetrics {
app_display_version: "Unknown".to_string(),
channel: None,
locale: None,
os_version: None,
}
}
}
Expand All @@ -36,7 +39,7 @@ impl From<ClientInfoMetrics> for glean_core::ClientInfoMetrics {
app_display_version: metrics.app_display_version,
channel: metrics.channel,
locale: metrics.locale,
os_version: system::get_os_version(),
os_version: metrics.os_version.unwrap_or_else(system::get_os_version),
windows_build_number: system::get_windows_build_number(),
architecture: system::ARCH.to_string(),
..Default::default()
Expand Down
1 change: 1 addition & 0 deletions glean-core/rlb/tests/collection_enabled.rs
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ fn nofollows_contains_client_info_when_collection_disabled() {
app_display_version: "1.0.0".to_string(),
channel: Some("testing".to_string()),
locale: Some("xx-XX".to_string()),
os_version: None,
};
glean::test_reset_glean(cfg, client_info, false);

Expand Down
1 change: 1 addition & 0 deletions glean-core/rlb/tests/collection_enabled_bin.rs
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ fn nofollows_contains_client_info_when_collection_disabled() {
app_display_version: "1.0.0".to_string(),
channel: Some("testing".to_string()),
locale: Some("xx-XX".to_string()),
os_version: None,
};
glean::test_reset_glean(cfg, client_info, false);

Expand Down
1 change: 1 addition & 0 deletions glean-core/rlb/tests/common/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ pub fn initialize(cfg: Configuration) {
app_display_version: "1.0.0".to_string(),
channel: Some("testing".to_string()),
locale: Some("xx-XX".to_string()),
os_version: None,
};

_ = PingBuilder::new("store1").with_send_if_empty(true).build();
Expand Down
1 change: 1 addition & 0 deletions glean-core/rlb/tests/schema.rs
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ fn validate_against_schema() {
app_display_version: env!("CARGO_PKG_VERSION").to_string(),
channel: Some("testing".to_string()),
locale: Some("xx-XX".to_string()),
os_version: None,
};

glean::initialize(cfg, client_info);
Expand Down
1 change: 1 addition & 0 deletions samples/rapid-metrics/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ fn main() {
app_display_version: env!("CARGO_PKG_VERSION").to_string(),
channel: None,
locale: None,
os_version: None,
};

_ = &*glean_metrics::prototype;
Expand Down
1 change: 1 addition & 0 deletions samples/rust/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ fn main() {
app_display_version: env!("CARGO_PKG_VERSION").to_string(),
channel: None,
locale: None,
os_version: None,
};

_ = &*glean_metrics::prototype;
Expand Down
Loading