Fix NoMethodError for format_run_start_day in RunSignupsFilenameFinder#11272
Merged
Fix NoMethodError for format_run_start_day in RunSignupsFilenameFinder#11272
Conversation
#11271) Move filename generators from a class-level constant into a private instance method so the lambdas close over self and can call instance methods.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NoMethodError: undefined method 'format_run_start_day' for class CsvExportsController::RunSignupsFilenameFinderPRIORITIZED_FILENAME_GENERATORSconstant was defined at the class body level, so lambdas inside it couldn't call instance methods likeformat_run_start_dayfilename_generatorsinstance method so the lambdas close overselfand can call instance methods correctlytest/controllers/csv_exports_controller_test.rbcovering the bug scenario and the single-run caseFixes #11271
Test plan
bin/rails test test/controllers/csv_exports_controller_test.rbpasses