phpdoc for Arrays::invoke() callables params#336
Open
spaze wants to merge 8 commits intonette:masterfrom
Open
Conversation
dg
force-pushed
the
master
branch
6 times, most recently
from
7c0abb7 to
bb3ea63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds phpdoc params to
$callbacksforArrays::invoke(). Without the params PHPStan fails with errors like(I wanted to use the 4.1.2 tag as a base ref for this PR, but there's no branch and GitHub doesn't let me create a PR when I select the tag as a base ref, so the base ref is the master branch but only for the PR, not for my branch. The change which added the line I'm changing is not in master. I'm not a git expert, not exactly sure what's going on here, sorry)