fix(unified-search): thumbnail icon

[alperozturk96]

Changes

Fixes thumnail generation for files
Adds overlays for folders
Fixes title alignment for folders
Fixes late async adapter initialization
De-duplicate folder thumbnail generation logic introduces re-usable OverlayManager class - for now it's only for folder
Removes dead-codes in DisplayUtils

Before	After

[alperozturk96]

/backport to stable-3.36

[AndyScherzinger]

Looks better 👍

@alperozturk96 @tobiasKaminsky One thing that should get fixed though is what gets tinted and that should only be folder-icons and the archive mimetype icon. Everything else shall keep their original icon's color (!)

[tobiasKaminsky]

PDF should not be tinted, but remain red

[tobiasKaminsky]

Add screenshot tests like AvatarIT for

• folders with
  • all sharing option
  • collective
  • auto upload
  • e2e
    --> in this PR
• files
  • all main mimetypes
    --> in new PR

[alperozturk96]

@AndyScherzinger

What are the licenses for these icons?

Latest version

[alperozturk96]

@tobiasKaminsky I added screenshot tests, but there is an issue related to view recycling.

At this line, if I remove the following code:

binding.thumbnail.apply {
           ....
            viewThemeUtils.platform.colorImageView(this, ColorRole.SECONDARY)
        }

the UI behaves incorrectly when scrolling, as shown in this screenshot:

---

Currently, only folders and archives should be tinted, while file type icons should remain unchanged. Glide’s asynchronous loading in the RecyclerView complicates this: even after removing Glide or setting setHasStableIds(true), the recycling issue persists.

In the current version of the PR, the UI appears correct, but screenshot tests capture greyed-out PDFs due to the colorImageView call at the beginning of bindRemoteThumbnail. Removing this code causes some icons to disappear because of recycling.

[github-actions]

Codacy

SpotBugs

Category	Base	New
Bad practice	42	42
Correctness	75	75
Dodgy code	256	256
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	2	2
Multithreaded correctness	34	34
Performance	44	44
Security	18	18
Total	479	479

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16546.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.