fix(contacts): handle line manager property creation#5304
Open
nfk wants to merge 1 commit intonextcloud:stable8.3from
Open
fix(contacts): handle line manager property creation#5304nfk wants to merge 1 commit intonextcloud:stable8.3from
nfk wants to merge 1 commit intonextcloud:stable8.3from
Conversation
hamza221
added
bug
hamza221
reviewed
May 7, 2026
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Adding the Line manager field created an empty x-managersname property and then immediately tried to focus the newly rendered editor. When the property had no matching contact value, the select received an undefined value and no focusable field was available. This produced the following JavaScript errors: - No focusable element found for property x-managersname - TypeError: can't access property "toLowerCase", this.localValue is undefined Keep empty manager properties represented as an empty string, guard select matching before lowercasing the local value, and store the only available manager using the vCard display name plus UID parameter instead of the internal contact key. Fixes nextcloud#4454 Signed-off-by: Nicolas Gelot <nicolas.gelot@e.email>
nfk
force-pushed
the
fix/line-manager-property
branch
from
bb82bc4 to
f7f6af4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the Line manager field created an empty x-managersname property and then immediately tried to focus the newly rendered editor. When the property had no matching contact value, the select received an undefined value and no focusable field was available.
This produced the following JavaScript errors:
Keep empty manager properties represented as an empty string, guard select matching before lowercasing the local value, and store the only available manager using the vCard display name plus UID parameter instead of the internal contact key.
Fixes #4454