fix(IMAP): don't add whitespaces to drafts#12196
Open
max65482 wants to merge 1 commit intonextcloud:mainfrom
Open
fix(IMAP): don't add whitespaces to drafts#12196max65482 wants to merge 1 commit intonextcloud:mainfrom
max65482 wants to merge 1 commit intonextcloud:mainfrom
Conversation
Contributor
Author
|
Could someone review? |
Contributor
|
Thanks for your pr 👍 So, it's not the regex that you mentioned in the issue? |
kesselb
force-pushed
the
fix/whitespaces-in-drafts
branch
from
76fb4f9 to
19d46fd
Compare
Contributor
Author
Yes, I was wrong. The regex is innocent. |
max65482
force-pushed
the
fix/whitespaces-in-drafts
branch
from
19d46fd to
90bcbf4
Compare
Contributor
Author
|
Failed integration tests should be fixed now. |
Signed-off-by: Maximilian Martin <maximilian_martin@gmx.de>
max65482
force-pushed
the
fix/whitespaces-in-drafts
branch
2 times, most recently
from
ad2cf9f to
4c97bd8
Compare
Contributor
|
Thanks a lot for your PR 👍 Sorry that the review takes so long 🙈 Your change works 💪 The commits b6d019b / https://github.com/nextcloud/mail/blame/c55f4d6f633b2865a2ecb16a30abdeddd1d4424c/lib/message.php doesn't give me any hint why the newlines were added. I'd hope @ChristophWurst has an idea? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12190