Skip to content

fix: rename ACommonsColumnsController to fix openapi attraction #2323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
enjeck merged 4 commits into from
Mar 3, 2026
Merged

fix: rename ACommonsColumnsController to fix openapi attraction #2323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
af8793d
fix: rename ACommonColumnsController to ACommonColumnsOCSController
joshtrichards Feb 12, 2026
8d14ca8
chore: rename ApiPublicColumnsController parent class
joshtrichards Feb 12, 2026
8fa0e8a
chore: rename ApiColumnsController parent class
joshtrichards Feb 12, 2026
721fab8
chore: composer openapi
enjeck Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Controller/ACommonColumnsController.php → ...ontroller/ACommonColumnsOCSController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
use OCA\Tables\Errors\PermissionError;
use OCA\Tables\Service\ColumnService;

abstract class ACommonColumnsController extends AOCSController {
abstract class ACommonColumnsOCSController extends AOCSController {
protected ColumnService $service;

/**
Expand Down
2 changes: 1 addition & 1 deletion lib/Controller/ApiColumnsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
/**
* @psalm-import-type TablesColumn from ResponseDefinitions
*/
class ApiColumnsController extends ACommonColumnsController {
class ApiColumnsController extends ACommonColumnsOCSController {


public function __construct(
Expand Down
2 changes: 1 addition & 1 deletion lib/Controller/ApiPublicColumnsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
/**
* @psalm-import-type TablesPublicColumn from ResponseDefinitions
*/
class ApiPublicColumnsController extends ACommonColumnsController {
class ApiPublicColumnsController extends ACommonColumnsOCSController {

public function __construct(
protected ColumnService $service,
Expand Down
Loading
Loading