test: update wpt by avivkeller · Pull Request #54468 · nodejs/node

avivkeller · 2024-08-20T22:29:26Z

This PR updates the WPT files.

Note the following behavioral differences between Node.js and WPT:

`test-structured-clone.js`

Comparison: https://wpt.fyi/results/html/webappapis/structured-clone/structured-clone.any.html
See: #55120

nodejs-github-bot · 2024-08-20T22:29:32Z

Review requested:

@nodejs/web-standards

test/wpt/status/WebCryptoAPI.json

Refs: nodejs#54572 Refs: nodejs#54468

avivkeller · 2024-08-27T16:41:40Z

This PR is a draft, and is no where near completion, but for record-keeping, this can't land until ~~#54468~~ #54593 does.

panva · 2024-08-27T16:43:07Z

This PR is a draft, and is no where near completion, but for record-keeping, this can't land until #54468 does.

Not necessarily, just stay clear of updating WebCryptoAPI as that will be done separately in #54593

avivkeller · 2024-08-27T16:44:54Z

Not necessarily, just stay clear of updating WebCryptoAPI as that will be done separately in #54593

Right, haha. I just to remove the WebCryptoAPI changes, and then fix the other failures...

Refs: #54572 Refs: #54468 PR-URL: #54593 Refs: #54572 Refs: #54468 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

avivkeller · 2024-08-29T16:51:58Z

FWIW This is currently blocked by the followings issues attempting to bring Node.js up-to-specification:
#54466 (and #54601)
#54617
#54602 #54603

panva · 2024-08-29T17:15:51Z

If you've opened the specific issues for nonconform behaviours and can add them as a note to the expectation files then this is fine to proceed.

avivkeller · 2024-08-29T17:17:06Z

Good to know. Thanks! I'll update this and proceed.

Refs: #54572 Refs: #54468 PR-URL: #54593 Refs: #54572 Refs: #54468 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Refs: nodejs#54572 Refs: nodejs#54468 PR-URL: nodejs#54593 Refs: nodejs#54572 Refs: nodejs#54468 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

nodejs-github-bot · 2024-09-07T23:44:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62129/

avivkeller · 2024-09-25T20:10:18Z

test/wpt/status/html/webappapis/structured-clone.json

+      "note12": "(1, 2) File is not (yet) transferrable. (3) SharedArrayBuffer does not extend ArrayBuffer",
+      "note3": "(3) SharedArrayBuffer does not extend ArrayBuffer",
+      "note4": "(4) https://github.com/nodejs/node/issues/55120",
+      "expected": [
+        "File basic",
+        "A subclass instance will deserialize as its closest serializable superclass",
+        "Growable SharedArrayBuffer",
+        "Serializing a non-serializable platform object fails"
+      ]


Review note:
~~File basic and A subclass instance will deserialize as its closest serializable superclass are being monitored at #47612~~

Growable SharedArrayBuffer is failing WPT because the test expects that SharedArrayBuffer extends ArrayBuffer, but it does not (AFAICT in Chromium and Node.js). I've manually tested that the behavior the WPT expects (regarding the clone, not the extension) passes on Node.js.

Serializing a non-serializable platform object fails is being monitored at #55120

codecov · 2024-09-25T21:41:11Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.24%. Comparing base (bdddc04) to head (341b6c2).
Report is 60 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #54468      +/-   ##
==========================================
- Coverage   88.25%   88.24%   -0.01%     
==========================================
  Files         651      651              
  Lines      183856   183856              
  Branches    35856    35853       -3     
==========================================
- Hits       162255   162252       -3     
+ Misses      14895    14883      -12     
- Partials     6706     6721      +15

see 24 files with indirect coverage changes

avivkeller · 2024-09-30T19:28:20Z

I'm closing this in favor of opening each update seperately, so some of them can be backported (if needed?)

Refs: nodejs#54572 Refs: nodejs#54468 PR-URL: nodejs#54593 Refs: nodejs#54572 Refs: nodejs#54468 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Refs: #54572 Refs: #54468 PR-URL: #54593 Backport-PR-URL: #58589 Refs: #54572 Refs: #54468 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 20, 2024

This was referenced Aug 23, 2024

tools: add WPT updater for specific subsystems #54460

Merged

subset of small-order Ed25519 vectors is failing in WPTs #54572

Open

panva reviewed Aug 26, 2024

View reviewed changes

test/wpt/status/WebCryptoAPI.json Outdated Show resolved Hide resolved

panva added a commit to panva/node that referenced this pull request Aug 27, 2024

test,crypto: update WebCryptoAPI WPT

e36c683

Refs: nodejs#54572 Refs: nodejs#54468

panva mentioned this pull request Aug 27, 2024

test,crypto: update WebCryptoAPI WPT #54593

Merged

avivkeller added the blocked PRs that are blocked by other issues or PRs. label Aug 27, 2024

avivkeller removed the blocked PRs that are blocked by other issues or PRs. label Aug 27, 2024

This was referenced Aug 28, 2024

Internal Assertion in AbortSignal #54601

Closed

Node.js allows the structedClone of objects that do "not have a transferable type." #54602

Closed

avivkeller added the blocked PRs that are blocked by other issues or PRs. label Aug 29, 2024

avivkeller removed the blocked PRs that are blocked by other issues or PRs. label Aug 29, 2024

avivkeller mentioned this pull request Aug 29, 2024

events: reset event state after dispatch #54642

Merged

jazelly mentioned this pull request Sep 7, 2024

lib: propagate aborted state to dependent signals before firing events #54826

Closed

avivkeller removed the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Sep 7, 2024

jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 7, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 7, 2024

test: update wpt

675bc44

avivkeller added test Issues and PRs related to the tests. and removed wip Issues and PRs that are still a work in progress. labels Sep 25, 2024

avivkeller marked this pull request as ready for review September 25, 2024 20:08

avivkeller commented Sep 25, 2024

View reviewed changes

fixup! update statuses

341b6c2

avivkeller added the needs-ci PRs that need a full CI run. label Sep 25, 2024

avivkeller closed this Sep 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test: update wpt#54468

test: update wpt#54468
avivkeller wants to merge 2 commits intonodejs:mainfrom
avivkeller:wpt

avivkeller commented Aug 20, 2024 •

edited

Loading

Uh oh!

nodejs-github-bot commented Aug 20, 2024

Uh oh!

Uh oh!

avivkeller commented Aug 27, 2024 •

edited

Loading

Uh oh!

panva commented Aug 27, 2024

Uh oh!

avivkeller commented Aug 27, 2024

Uh oh!

avivkeller commented Aug 29, 2024 •

edited

Loading

Uh oh!

panva commented Aug 29, 2024

Uh oh!

avivkeller commented Aug 29, 2024

Uh oh!

nodejs-github-bot commented Sep 7, 2024

Uh oh!

avivkeller Sep 25, 2024 •

edited

Loading

Uh oh!

codecov bot commented Sep 25, 2024 •

edited

Loading

Uh oh!

avivkeller commented Sep 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

avivkeller commented Aug 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

test-structured-clone.js

Uh oh!

nodejs-github-bot commented Aug 20, 2024

Uh oh!

Uh oh!

avivkeller commented Aug 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

panva commented Aug 27, 2024

Uh oh!

avivkeller commented Aug 27, 2024

Uh oh!

avivkeller commented Aug 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

panva commented Aug 29, 2024

Uh oh!

avivkeller commented Aug 29, 2024

Uh oh!

nodejs-github-bot commented Sep 7, 2024

Uh oh!

avivkeller Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

avivkeller commented Sep 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

avivkeller commented Aug 20, 2024 •

edited

Loading

`test-structured-clone.js`

avivkeller commented Aug 27, 2024 •

edited

Loading

avivkeller commented Aug 29, 2024 •

edited

Loading

avivkeller Sep 25, 2024 •

edited

Loading

codecov bot commented Sep 25, 2024 •

edited

Loading