doc: simplify addAbortListener example#61842
Open
atlowChemi wants to merge 1 commit intonodejs:mainfrom
Open
Conversation
nodejs-github-bot
added
doc
atlowChemi
force-pushed
the
use-the-using-keyword
branch
from
a82b1f5 to
83dbc3e
Compare
The example was written before v8 supported the using keyword and hence explicitly called Symbol.dispose Since now the keyword is supported, the example can be simplified
atlowChemi
force-pushed
the
use-the-using-keyword
branch
from
83dbc3e to
b6097b8
Compare
Renegade334
reviewed
Feb 15, 2026
Comment on lines
+1912
to
+1914
| using _ = addAbortListener(signal, (e) => { | ||
| // Do something when signal is aborted. | ||
| }); |
Member
There was a problem hiding this comment.
I think it would be worth adding a comment underneath to state that the abort listener is automatically removed when leaving the scope, otherwise the significance of the using statement doesn't have any immediate context to the casual observer.
Renegade334
added
dont-land-on-v20.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example was written before v8 supported the using keyword and hence explicitly called
Symbol.dispose.Since now the keyword is supported, the example can be simplified.