crypto: add signDigest/verifyDigest and Ed25519ctx support#62345
Open
panva wants to merge 4 commits intonodejs:mainfrom
Open
crypto: add signDigest/verifyDigest and Ed25519ctx support#62345panva wants to merge 4 commits intonodejs:mainfrom
panva wants to merge 4 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
This was referenced Mar 19, 2026
Contributor
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
Codecov Reportβ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62345 +/- ##
========================================
Coverage 89.68% 89.69%
========================================
Files 676 676
Lines 206689 206798 +109
Branches 39579 39615 +36
========================================
+ Hits 185370 185484 +114
+ Misses 13450 13444 -6
- Partials 7869 7870 +1
π New features to boost your workflow:
|
ChALkeR
reviewed
Mar 20, 2026
ChALkeR
reviewed
Mar 20, 2026
Member
|
Not entirely certain how this works, will test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
notable-changePRs with changes that should be highlighted in changelogs.
π
Adds
crypto.signDigest()andcrypto.verifyDigest(), one-shot functions that sign/verify a pre-computed hash digest directly, without hashing internally.Supports RSA (PKCS#1 v1.5, PSS), ECDSA, DSA, Ed25519, and Ed448.
Also adds Ed25519 context string support to
crypto.sign(),crypto.verify()as well as the new methods.Resolves: #60263
Pre-hash variants of Ed25519 and Ed448 as well Ed25519 context is defined in RFC8032