Open
Conversation
This reverts commit 5bebd7e. The update appears to be causing persistent flakiness in test-http(s), test-net-*, and test-tls-* tests on Windows. The flakiness manifests as an abort apparently caused by a race condition introduced in connection cleanup on process teardown. Root cause still needs to be fully determined. Reverting the update will hopefully get us back to a stable state while the underlying issue is investigated and resolved.
Collaborator
|
Review requested:
|
nodejs-github-bot
added
libuv
Member
Author
|
Note that i was able to repro the issue on windows locally; and after applying the revert locally it has not reoccurred yet. |
anonrig
approved these changes
Mar 29, 2026
Member
|
cc @nodejs/libuv |
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62497 +/- ##
========================================
Coverage 89.70% 89.71%
========================================
Files 691 692 +1
Lines 213935 214039 +104
Branches 41050 41065 +15
========================================
+ Hits 191907 192015 +108
+ Misses 14095 14092 -3
+ Partials 7933 7932 -1 🚀 New features to boost your workflow:
|
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 5bebd7e.
The update appears to be causing persistent flakiness in test-http(s), test-net-, and test-tls- tests on Windows. The flakiness manifests as an abort apparently caused by a race condition introduced in connection cleanup on process teardown. Root cause still needs to be fully determined. Reverting the update will hopefully get us back to a stable state while the underlying issue is investigated and resolved.