crypto: accept key data in crypto.diffieHellman() and cleanup DH jobs#62527
Open
panva wants to merge 1 commit intonodejs:mainfrom
Open
crypto: accept key data in crypto.diffieHellman() and cleanup DH jobs#62527panva wants to merge 1 commit intonodejs:mainfrom
panva wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62527 +/- ##
==========================================
- Coverage 89.72% 89.71% -0.01%
==========================================
Files 695 695
Lines 214106 214087 -19
Branches 41002 40986 -16
==========================================
- Hits 192096 192071 -25
- Misses 14077 14104 +27
+ Partials 7933 7912 -21
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept key data in addition to KeyObject instances in
crypto.diffieHellman(options)asoptions.privateKeyandoptions.publicKey, same inputs like in the othernode:cryptofunctions.