feat(DEP0194): migrate http2 priority signalling

[AugustinMauroy]

I'm not sure if I correctly get, how the deprecation should be handled so here my thing.

Resolves #243

[Copilot]

Pull Request Overview

This PR introduces a new codemod recipe to handle Node.js deprecation DEP0194 by automatically removing HTTP/2 priority-related options and methods from codebases. The codemod removes priority properties from http2.connect(), session.request(), and client.settings() calls, as well as entire stream.priority() method invocations.

Key Changes:

• Implements AST transformation logic to detect and remove deprecated HTTP/2 priority signaling code
• Provides comprehensive test coverage for CommonJS and ESM imports across multiple usage scenarios
• Includes complete recipe configuration and documentation

Reviewed Changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
recipes/http2-priority-signaling/src/workflow.ts	Core transformation logic implementing removal of priority-related code
recipes/http2-priority-signaling/workflow.yaml	Workflow configuration defining the codemod execution
recipes/http2-priority-signaling/package.json	Package metadata and dependencies
recipes/http2-priority-signaling/codemod.yaml	Codemod registry configuration
recipes/http2-priority-signaling/README.md	Documentation explaining the codemod's purpose and usage
recipes/http2-priority-signaling/tests/input/*.js	Test input files covering different priority removal scenarios
recipes/http2-priority-signaling/tests/expected/*.js	Expected output files showing correct transformation results

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[AugustinMauroy]

Bruno I tried to solve issue that you had found but idk if there are a better way to accomplish that.

[brunocroh]

Bruno I tried to solve issue that you had found but idk if there are a better way to accomplish that.

In #248, I handled a very similar scenario. What I did there was identify the function that returns directory objects, track those variables, and check if their methods were invoked. I think you need to do something similar here with the session/stream.

For example, identify the variable named session, get the scope where it’s defined, and check if that variable uses the deprecated method within that scope.

const http2 = require('node:http2')

function ex() {
  let session = http2.connect(/* ... */)
  session.settigns(/* ... */)
}

let session = {
  settings: () => console.log('this function cannot be removed/updated by codemod')
}

let anyName = {
  settings: () => console.log('this function cannot be removed/updated by codemod')
}

session.settings()
anyName.settings()

To do that, you probably need something like this:

• Identify resolveBind in http2.connect.
• Check for usages of http2.connect and identify where its returned value is stored(variable name).
• Determine the context where this variable is valid.
• Look for method usages that need to be replaced of that variable within the valid context.

[AugustinMauroy]

Normally it's fine, but I admit it's more complex than expected.

[JakobJingleheimer]

I'm not sure if I correctly get, how the deprecation should be handled so here my thing.

If we're not sure, let's ask someone who would know rather than guess. Perhaps James Snell?

[jasnell]

It's been a bit since I've thought about this but generally lgtm.

[JakobJingleheimer]

Thank you @jasnell 🙏

[brunocroh]

I leave some nitpicking coments, but feel free to land it, it is g2g

[JakobJingleheimer]

nit: getModuleDependencies

[JakobJingleheimer]

Suggested change

	// If any import do nothing
	// If no imports, nothing to do

[JakobJingleheimer]

Suggested change

	// If callee already includes a dot (e.g., http2.connect), the pattern above already matches it.
	// If callee already includes a dot (e.g., http2.connect), the pattern above already matched it.

[JakobJingleheimer]

nit for consistency

Suggested change

	while (n && n.kind() !== 'variable_declarator') {
	n = n.parent();
	}
	while (n && n.kind() !== 'variable_declarator') n = n.parent();

[JakobJingleheimer]

nit: helps break it up visually

Suggested change

	if (!n) continue;
	if (!n) continue;

[JakobJingleheimer]

same nit

Suggested change

	if (!nameNode) continue;
	if (!nameNode) continue;