feat(`axios-to-whatwg-fetch`): introduce by AugustinMauroy · Pull Request #269 · nodejs/userland-migrations

AugustinMauroy · 2025-11-08T11:52:29Z

Related issue

close #191

info https://socket.dev/blog/axios-npm-package-compromised

JakobJingleheimer · 2025-11-09T11:41:11Z

omg please yes

AugustinMauroy · 2025-12-13T09:46:57Z

cc @nodejs/userland-migrations can I have first review on this one

Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>

AugustinMauroy · 2026-01-17T15:46:43Z

@JakobJingleheimer I tried to apply all of your proposal.

But why the ci didn't ran ?

JakobJingleheimer · 2026-01-17T16:10:51Z

It looks like CI did run?

If not, was this whilst I was fiddling with the repo permissions? (I specifically told you on slack you'd temporarily have read-only permissions for a bit, which means you couldn't do anything other than read within the repo)

AugustinMauroy · 2026-01-17T16:16:20Z

It looks like CI did run?

If not, was this whilst I was fiddling with the repo permissions? (I specifically told you on slack you'd temporarily have read-only permissions for a bit, which means you couldn't do anything other than read within the repo)

it's ran after the merge commit. idk what really happened but it's work now !

it's didn't help since I dunno why windows is doing windows thing

JakobJingleheimer

Great tidy!

It's still missing handling for transformRequest, transformResponse, paramsSerializer, etc, which was the blocker before. It needs to either

support them
detect them and abort/fail the migration

Doing neither will result in broken userland code.

AugustinMauroy · 2026-04-06T07:34:09Z

@JakobJingleheimer applied your proposal

JakobJingleheimer

🙌

JakobJingleheimer · 2026-04-23T21:00:31Z

+	'transformRequest',
+	'transformResponse',
+	'paramsSerializer',
+	'withCredentials',
+	'timeout',
+	'httpAgent',
+	'httpsAgent',
+	'validateStatus',
+	'maxRedirects',
+	'socketPath',
+	'decompress',
+	'maxContentLength',
+	'maxBodyLength',
+	'beforeRedirect',
+	'cancelToken',
+	'signal',


nit: for the grok

Suggested change

'transformRequest',

'transformResponse',

'paramsSerializer',

'withCredentials',

'timeout',

'httpAgent',

'httpsAgent',

'validateStatus',

'maxRedirects',

'socketPath',

'decompress',

'maxContentLength',

'maxBodyLength',

'beforeRedirect',

'cancelToken',

'signal',

'beforeRedirect',

'cancelToken',

'decompress',

'httpAgent',

'httpsAgent',

'maxBodyLength',

'maxContentLength',

'maxRedirects',

'paramsSerializer',

'signal',

'socketPath',

'timeout',

'transformRequest',

'transformResponse',

'validateStatus',

'withCredentials',

JakobJingleheimer · 2026-04-23T21:05:57Z

+	'beforeRedirect',
+	'cancelToken',
+	'signal',
+];


Suggested change

];

] as const;

JakobJingleheimer · 2026-04-23T21:07:46Z

+	}
+
+	return { unsupported: false };
+};


There could be more than one; I think it would be useful to report them all to the user. In that case, I think it would make sense to do something like

function getUnsupportedOptions(configNode?: SgNode<Js>): false | (typeof UNSUPPORTED_CONFIG_OPTIONS)[number][];

JakobJingleheimer · 2026-04-23T21:09:41Z

+	// if it's already a FormData or URLSearchParams instance, return as is
+	// we only check for common instantiation patterns here maybe add complex ones later


nit

Suggested change

// if it's already a FormData or URLSearchParams instance, return as is

// we only check for common instantiation patterns here maybe add complex ones later

// if it's already a FormData or URLSearchParams instance, return as-is

// we only check for common instantiation patterns here—maybe add complex ones later?

JakobJingleheimer · 2026-04-23T21:11:24Z

+	},
+});
+
+const axiosMethodUpdates: AxiosMethodUpdateConfig[] = [


Better to use satisfies

Suggested change

const axiosMethodUpdates: AxiosMethodUpdateConfig[] = [

const axiosMethodUpdates = [

JakobJingleheimer · 2026-04-23T21:11:50Z

+		oldOptionsIndex: 1,
+		optionalOptionsArg: false,
+	},
+];


Suggested change

];

] satisfies AxiosMethodUpdateConfig[];

JakobJingleheimer · 2026-04-23T21:12:05Z

+const baseUpdates: {
+	oldBind: string;
+	replaceFn: BindingToReplace['replaceFn'];
+	supportDefaultAccess?: boolean;
+}[] = [


Suggested change

const baseUpdates: {

oldBind: string;

replaceFn: BindingToReplace['replaceFn'];

supportDefaultAccess?: boolean;

}[] = [

const baseUpdates = [

JakobJingleheimer · 2026-04-23T21:12:26Z

+	`;
+		},
+	},
+];


Suggested change

];

] satisfies {

oldBind: string;

replaceFn: BindingToReplace['replaceFn'];

supportDefaultAccess?: boolean;

}[];

JakobJingleheimer · 2026-04-23T21:13:37Z

+			return dedent.withOptions({ alignValues: true })`
+	fetch(${url}${options ? `, ${options}` : ''})
+		.then(async (resp) => Object.assign(resp, { data: await resp.json() }))
+		.catch(() => null)
+	`;


nit: since this is dedented, can the indentation here be "proper"?

Suggested change

return dedent.withOptions({ alignValues: true })`

fetch(${url}${options ? `, ${options}` : ''})

.then(async (resp) => Object.assign(resp, { data: await resp.json() }))

.catch(() => null)

`;

return dedent.withOptions({ alignValues: true })`

fetch(${url}${options ? `, ${options}` : ''})

.then(async (resp) => Object.assign(resp, { data: await resp.json() }))

.catch(() => null)

`;

JakobJingleheimer · 2026-04-23T21:15:58Z

+		},
+	},
+	{
+		oldBind: '$.request',


Ohh 🤦 👍

I think still better to errorWithLocation (because something failed).

brunocroh and others added 17 commits September 3, 2025 19:57

wip

6f94b7a

wip

e51e1cb

wip

b74ed68

wip

320dd82

wip

84c09b7

wip

9bfe594

wip

a08cf23

wip

335b801

wip

398aa8e

Merge branch 'main' into feat/axios-to-whatwg-fetch

85325e9

Update

667a821

add jsdoc

c828c60

write readme

8a5629a

test: correct white space

ca6dc94

update dep

8cf7ab6

wip

691931d

Update package-lock.json

4eb9d44

AugustinMauroy added the awaiting reviewer Author has responded and needs action from the reviewer label Nov 8, 2025

AugustinMauroy requested review from a team and removed request for a team November 8, 2025 13:49

AugustinMauroy removed the awaiting reviewer Author has responded and needs action from the reviewer label Nov 8, 2025

AugustinMauroy marked this pull request as draft November 8, 2025 13:50

AugustinMauroy added 4 commits November 24, 2025 13:14

feat(axios-to-whatwg-fetch): add support request

7064c88

WIP

560db6d

update

faf6ac2

include tsx

03a36d7

AugustinMauroy requested a review from a team December 10, 2025 10:34

AugustinMauroy added the awaiting reviewer Author has responded and needs action from the reviewer label Dec 13, 2025

AugustinMauroy and others added 6 commits January 17, 2026 16:08

Update recipes/axios-to-whatwg-fetch/src/workflow.ts

85beb77

Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>

Update recipes/axios-to-whatwg-fetch/src/workflow.ts

8f11004

Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>

WIP

890c10f

fix formating in output

2b8a759

wip

c4a29b2

WIP

baa2632

Merge branch 'main' into feat/axios-to-whatwg-fetch

631d0da

AugustinMauroy added awaiting reviewer Author has responded and needs action from the reviewer and removed awaiting author Reviewer has requested something from the author labels Jan 17, 2026

JakobJingleheimer requested changes Jan 25, 2026

View reviewed changes

JakobJingleheimer added awaiting author Reviewer has requested something from the author and removed awaiting reviewer Author has responded and needs action from the reviewer labels Jan 25, 2026

avivkeller reviewed Feb 2, 2026

View reviewed changes

Comment thread recipes/axios-to-whatwg-fetch/src/workflow.ts Outdated

AugustinMauroy added 5 commits March 6, 2026 09:41

Merge branch 'main' into feat/axios-to-whatwg-fetch

6bb3e44

update

3d5bef7

Update test.ts

1284d39

add unsuported api

a6d4eba

update test struct

469e199

AugustinMauroy force-pushed the feat/axios-to-whatwg-fetch branch from d1ae93f to 469e199 Compare April 6, 2026 07:33

AugustinMauroy added awaiting reviewer Author has responded and needs action from the reviewer and removed awaiting author Reviewer has requested something from the author labels Apr 6, 2026

AugustinMauroy added 2 commits April 6, 2026 09:37

fix windows on test

2155d5f

Merge branch 'main' into feat/axios-to-whatwg-fetch

43251bd

brunocroh approved these changes Apr 15, 2026

View reviewed changes

JakobJingleheimer approved these changes Apr 23, 2026

View reviewed changes

JakobJingleheimer removed the awaiting reviewer Author has responded and needs action from the reviewer label Apr 23, 2026

		// if it's already a FormData or URLSearchParams instance, return as is
		// we only check for common instantiation patterns here maybe add complex ones later

	const axiosMethodUpdates: AxiosMethodUpdateConfig[] = [
	const axiosMethodUpdates = [

Uh oh!

Conversation

AugustinMauroy commented Nov 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related issue

Uh oh!

JakobJingleheimer commented Nov 9, 2025

Uh oh!

AugustinMauroy commented Dec 13, 2025

Uh oh!

AugustinMauroy commented Jan 17, 2026

Uh oh!

JakobJingleheimer commented Jan 17, 2026

Uh oh!

AugustinMauroy commented Jan 17, 2026

Uh oh!

JakobJingleheimer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AugustinMauroy commented Apr 6, 2026

Uh oh!

JakobJingleheimer left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AugustinMauroy commented Nov 8, 2025 •

edited

Loading