Draft
Conversation
Open
# Conflicts: # src/interactions/brush.d.ts # src/interactions/brush.js # test/plots/brush.ts
Contributor
Author
|
A diagram of the whole system: Each of these PRs can be reviewed independently:
The "merge" PR #2370 is for testing that everything works together. |
Fil
changed the base branch from
fil/brush-dataless
to
fil/brush-data-options
Fil
changed the base branch from
fil/brush-data-options
to
fil/brush-across-facets
Fil
changed the base branch from
fil/brush-across-facets
to
fil/brush-data-options
# Conflicts: # src/interactions/brush.js # test/plots/brush.ts
|
I just went through all of the tests, looking great! The only thing I noted was the sticky tooltip behavior that I mentioned in the tip+brush PR. |
it needs to be an object since context gets spread in src/interactions/pointer.js:25
# Conflicts: # docs/interactions/brush.md # src/interactions/brush.d.ts
Fil
force-pushed
the
fil/brush-data-options
branch
from
730aa57 to
4d19cab
Compare
Fil
force-pushed
the
fil/brush-merge
branch
2 times, most recently
from
c9d40f9 to
d9d64e1
Compare
# Conflicts: # docs/interactions/brush.md
# Conflicts: # docs/interactions/brush.md # src/interactions/brush.d.ts # test/brush-test.ts
Combines multi-plot brush reuse (per-plot state via context.interaction, cross-plot sync in data space, WeakMap-based renderFilter updates) with data/styling support (brush(data, options), filterData, applyAttr). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Combines multi-plot brush reuse with data/styling support and brush-across-facets (context.interaction.brushing flag).
Plot.brush() without data should not call maybeTuple, which would set default channel accessors and require scales to exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch merges all the branches that depend on
fil/brush-dataless(#2360), fixes the conflicts, and changes the tests and examples of cross-facet brushing to a timelineEnregistrement.de.l.ecran.2026-02-20.a.16.26.58.mov
(This branch combines everything, so while it may be better for testing, it's probably not as good for reviewing.)