Remove pointless temp files uses for dependency analysis#13629
Draft
rgrinberg wants to merge 1 commit intoocaml:mainfrom
Draft
Remove pointless temp files uses for dependency analysis#13629rgrinberg wants to merge 1 commit intoocaml:mainfrom
rgrinberg wants to merge 1 commit intoocaml:mainfrom
Conversation
rgrinberg
force-pushed
the
push-nmsvvokuzmur
branch
from
317b5b8 to
3318681
Compare
There's no point to save the computation of transitive closures. These are very quick to compute on the fly since everything is in memory. If we ever consider caching them again, creating 2 files per module isn't the way to go anyway. Signed-off-by: Rudi Grinberg <me@rgrinberg.com> <!-- ps-id: ae00b7cc-c09a-42f7-8d27-bc0e73567f37 --> Signed-off-by: Rudi Grinberg <me@rgrinberg.com> refactor: attempt to speed up Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-nmsvvokuzmur
branch
from
3318681 to
6f8a5b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no point to save the computation of transitive closures. These are very quick to compute on the fly since everything is in memory.
If we ever consider caching them again, creating 2 files per module isn't the way to go anyway.