fix(contracts): remove msg.value != _value check in depositTransaction#219
Open
fix(contracts): remove msg.value != _value check in depositTransaction#219
Conversation
This check prevents force inclusion value transfers on CGT chains. In CGT mode, msg.value must be 0, which forces _value to also be 0. This blocks legitimate use of existing L2 balance via deposit transactions. The upstream ethereum-optimism does not have this check. Removing it allows EOAs to force include native token (OKB) transfers on L2 using their existing L2 balance, without any L1→L2 asset bridging. Safety: mint is determined by msg.value (=0), so no tokens are created. The EVM layer validates sender has sufficient L2 balance before transferring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This check prevents force inclusion value transfers on CGT chains. In CGT mode, msg.value must be 0, which forces _value to also be 0. This blocks legitimate use of existing L2 balance via deposit transactions.
The upstream ethereum-optimism does not have this check. Removing it allows EOAs to force include native token (OKB) transfers on L2 using their existing L2 balance, without any L1→L2 asset bridging.
Safety: mint is determined by msg.value (=0), so no tokens are created. The EVM layer validates sender has sufficient L2 balance before transferring.