[CODE HEALTH] Fix clang-tidy macro to enum warnings

[marcalff]

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

• Fix clang-tidy cppcoreguidelines-macro-to-enum warnings
• Remove dead code related to MAX_LOGGER_COUNT

For significant contributions please make sure you have completed the following items:

• CHANGELOG.md updated for non-trivial changes
• Unit tests have been added
• Changes in public API reviewed

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.06%. Comparing base (739862d) to head (92ecd12).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3922   +/-   ##
=======================================
  Coverage   90.06%   90.06%           
=======================================
  Files         226      226           
  Lines        7223     7223           
=======================================
  Hits         6505     6505           
  Misses        718      718           

Files with missing lines	Coverage Δ
sdk/src/logs/logger_provider.cc	89.14% <ø> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ThomsonTan]

Include the above OPENTELEMETRY_ABI_VERSION_NO definition in the // NOLINTBEGIN section too?

[marcalff]

Fixed.