WEB-666 Recurring deposit product form negative values allowed in settings fields

[JaySoni1]

Changes Made :-

-Prevent negative values for settings fields in Recurring Deposit Product form .

WEB-666

Before :-

After :-

Summary by CodeRabbit

• Bug Fixes
  • Recurring deposit product settings now enforce non-negative values for locking period frequency, deposit terms, and penalty interest fields.

[coderabbitai]

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)

Validation error: Unrecognized key(s) in object: 'pre_merge_checks'

⚙️ Configuration instructions

• Please see the configuration documentation for more information.
• You can also validate your configuration using the online YAML validator.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

This PR adds client-side and server-side validation to enforce non-negative values for numeric form controls in the recurring deposit product settings, specifically for fields including locking period frequency, deposit terms, and pre-closure penalty interest.

Changes

Cohort / File(s)	Summary
Recurring Deposit Product Settings Validation src/app/products/.../recurring-deposit-product-settings-step.component.html, src/app/products/.../recurring-deposit-product-settings-step.component.ts	Added min="0" HTML attributes and Validators.min(0) form validators to five numeric input fields: lockinPeriodFrequency, minDepositTerm, inMultiplesOfDepositTerm, maxDepositTerm, and preClosurePenalInterest.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

• WEB-462 Lock in period field allows zero and negative values in save product creation form #2888: Adds similar min(0) validation for lockinPeriodFrequency field in saving-products component, addressing consistent validation patterns across product types.

Suggested reviewers

• alberto-art3ch
• IOhacker

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: preventing negative values in recurring deposit product settings fields through validation constraints.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[alberto-art3ch]

Please be sure that optional fields remains as is.

[JaySoni1]

@alberto-art3ch I will update the PR

[alberto-art3ch]

LGTM

[JaySoni1]

@alberto-art3ch Thank You for the review