Fix Client.request returning raw strings instead of dicts#12
Open
Deadpool2000 wants to merge 1 commit intoopenapi:mainfrom
Open
Fix Client.request returning raw strings instead of dicts#12Deadpool2000 wants to merge 1 commit intoopenapi:mainfrom
Deadpool2000 wants to merge 1 commit intoopenapi:mainfrom
Conversation
…n Client.request fix: decode raw JSON strings to dictionaries in client.request() to remove Flask boilerplate fix: natively decode stringified API responses into JSON dicts within the SDK~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6 I noticed that Client.request() sometimes returns double-encoded JSON as a raw string instead of a parsed dictionary. This forces users (especially in Flask apps) to manually write json.loads(resp) repeatedly, which is a bit of a hassle.
This PR fixes that by ensuring we automatically decode the string into a dict under the hood, saving everyone from writing extra boilerplate.
Let me know if you need any changes!