Merged
Conversation
tobiasgrosser
approved these changes
Apr 2, 2026
Collaborator
tobiasgrosser
left a comment
tobiasgrosser
left a comment
There was a problem hiding this comment.
LGTM. Instead of referring to lean-mlir's behavior, can you describe what changes in your PR message?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We fix the instruction selection lowering pattern for the
liinstruction using the newregtype and the unrealized conversion cast. We lower anllvm.constantoperation to ariscv.lioperation with the same property (i.e., the value of the constant), followed by an unrealized conversion cast. This ensures type consistency in a progressive lowering.At the moment, we only support
i64types. We will expand this in a future PR, after inspecting LLVM's behaviour closely.