8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check by zangcq · Pull Request #622 · openjdk/jdk8u-dev

zangcq · 2025-02-12T09:05:57Z

Hi all,

This is backport JDK-8261235 from jdk17 to jdk8u-dev, to fix C1 compilation failed in HugeMethods.

File 'hotspot/test/compiler/c1/TestTooManyVirtualRegistersMain.java' remove annotation ' @requires vm.compiler1.enabled
'
other file mainly in copyrighht year different.

it's necessary for jdk8u-dev.

Change has been verified locally, we do test jdk-tier1 tier2 and hotspot-tier1 passed, no risk.

Issue

JDK-8261235 : C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check

I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
JDK-8261235 needs maintainer approval
Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

JDK-8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check (Bug - P3 - Approved)

Reviewers

Christian Hagedorn (@chhagedorn - no project role) Review applies to c44095fd
Roland Westrelin (@rwestrel - Reviewer)
Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/622/head:pull/622
$ git checkout pull/622

Update a local copy of the PR:
$ git checkout pull/622
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/622/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 622

View PR using the GUI difftool:
$ git pr show -t 622

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/622.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-02-12T09:06:40Z

Hi @zangcq, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user zangcq" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

openjdk · 2025-02-12T09:07:03Z

@zangcq This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check

Reviewed-by: roland, serb, chagedorn
Backport-of: 84182855307ec8c370aceeaed839c545b7ae1d69

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

349af97: Merge
73c9c6b: 8328999: Update GIFlib to 5.2.2
62bb5f8: 8379035: (tz) Update Timezone Data to 2026a
... and 18 more: https://git.openjdk.org/jdk8u-dev/compare/40a612ca8f0aad0d1d2fe0b7bb581f08c0d0709a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rwestrel, @mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

zangcq · 2025-02-12T09:13:53Z

/covered

bridgekeeper · 2025-02-12T09:14:29Z

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

openjdk · 2025-02-21T03:46:23Z

This backport pull request has now been updated with issue from the original commit.

mlbridge · 2025-03-10T15:13:35Z

Webrevs

zangcq · 2025-03-12T02:09:59Z

Hi @chhagedorn , I will backport your patch to jdk8 , could you please review this patch?

chhagedorn

Otherwise, looks good to me!

chhagedorn · 2025-03-12T07:44:20Z

  assert(_insertion_buffer.lir_list() == _insert_list, "wrong insertion buffer");

-  LIR_Opr to_opr = LIR_OprFact::virtual_register(to_interval->reg_num(), to_interval->type());
+  LIR_Opr to_opr =get_virtual_register(to_interval);


Suggested change

LIR_Opr to_opr =get_virtual_register(to_interval);

LIR_Opr to_opr = get_virtual_register(to_interval);

thanks for your suggestion, Fixed :-)

zangcq · 2025-03-14T06:08:45Z

Hi @gnu-andrew , could you please review this patch? hagedorn just have read-only permissions.

zangcq · 2025-03-18T03:06:03Z

/approval

openjdk · 2025-03-18T03:06:26Z

@zangcq usage: /approval [<id>] (request|cancel) [<text>]

zangcq · 2025-03-18T03:08:45Z

/approval 8261235 request C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check

openjdk · 2025-03-18T03:09:23Z

@zangcq usage: /approval [<id>] (request|cancel) [<text>]

zangcq · 2025-03-18T03:10:22Z

/approval request allow 8261235

openjdk · 2025-03-18T03:11:14Z

@zangcq
8261235: The approval request has been created successfully.

bridgekeeper · 2025-04-15T05:44:43Z

@zangcq This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

zangcq · 2025-05-06T01:57:49Z

Kindly ping @gnu-andrew , could you please review this patch? hagedorn just have read-only permissions.

bridgekeeper · 2026-03-11T01:53:58Z

@zangcq This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

mrserb · 2026-03-11T18:39:33Z

/touch

openjdk · 2026-03-11T18:40:25Z

@mrserb The pull request is being re-evaluated and the inactivity timeout has been reset.

bridgekeeper · 2026-04-09T02:04:54Z

@zangcq This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

mrserb · 2026-04-09T05:21:17Z

+ * @compile TestTooManyVirtualRegisters.jasm
+ * @run main/othervm -Xbatch -XX:CompileCommand=dontinline,compiler.c1.TestExceptionBlockWithPredecessors::*
+ *                   compiler.c1.TestTooManyVirtualRegistersMain
+ */


Note that there is a typo here, the wrong name is used for CompileCommand.
I have filed: https://bugs.openjdk.org/browse/JDK-8381880

Appreciate it for your comments，should we fix this typo in this pr？

no that is a separate issue, and it does not affect the ability to reproduce the bug.

zangcq · 2026-04-13T01:51:24Z

/integrate

openjdk · 2026-04-13T01:52:08Z

@zangcq
Your change (at version db5b350) is now ready to be sponsored by a Committer.

jerboaa · 2026-04-13T08:09:05Z

/sponsor

openjdk · 2026-04-13T08:10:25Z

@jerboaa This PR has not yet been marked as ready for integration.

jerboaa · 2026-04-13T08:10:40Z

@zangcq You need to issue /template append and confirm the AI policy before this can be integrated.

zangcq · 2026-04-13T08:11:05Z

/template append - [x] I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy

openjdk · 2026-04-13T08:13:29Z

@zangcq The pull request template has been appended to the pull request body

zangcq · 2026-04-13T08:19:37Z

@zangcq You need to issue /template append and confirm the AI policy before this can be integrated.

Thanks for your advice，done

jerboaa · 2026-04-13T09:49:16Z

/sponsor

openjdk · 2026-04-13T09:50:08Z

Going to push as commit 8dc952f.
Since your change was applied there have been 21 commits pushed to the master branch:

349af97: Merge
73c9c6b: 8328999: Update GIFlib to 5.2.2
62bb5f8: 8379035: (tz) Update Timezone Data to 2026a
... and 18 more: https://git.openjdk.org/jdk8u-dev/compare/40a612ca8f0aad0d1d2fe0b7bb581f08c0d0709a...master

Your commit was automatically rebased without conflicts.

openjdk · 2026-04-13T09:50:17Z

@jerboaa @zangcq Pushed as commit 8dc952f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

bridgekeeper bot added the oca Needs verification of OCA signatory status label Feb 12, 2025

bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Feb 12, 2025

zangcq changed the title ~~8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check~~ Backport 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check Feb 12, 2025

zangcq changed the title ~~Backport 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check~~ 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check Feb 18, 2025

zangcq changed the title ~~8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check~~ Backport 84182855 "8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check" Feb 20, 2025

zangcq changed the title ~~Backport 84182855 "8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check"~~ Backport 84182855307ec8c370aceeaed839c545b7ae1d69 Feb 21, 2025

openjdk bot changed the title ~~Backport 84182855307ec8c370aceeaed839c545b7ae1d69~~ 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check Feb 21, 2025

openjdk bot added the backport Port of a pull request already in a different code base label Feb 21, 2025

bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Mar 10, 2025

openjdk bot added the rfr Pull request is ready for review label Mar 10, 2025

chhagedorn approved these changes Mar 12, 2025

View reviewed changes

chhagedorn approved these changes Mar 14, 2025

View reviewed changes

openjdk bot added the approval Requires approval; will be removed when approval is received label Mar 18, 2025

mrserb approved these changes Apr 9, 2026

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 9, 2026

mrserb reviewed Apr 9, 2026

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 13, 2026

openjdk bot removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 13, 2026

openjdk bot added sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 13, 2026

openjdk bot added the integrated Pull request has been integrated label Apr 13, 2026

openjdk bot closed this Apr 13, 2026

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 13, 2026

	LIR_Opr to_opr =get_virtual_register(to_interval);
	LIR_Opr to_opr = get_virtual_register(to_interval);

Conversation

zangcq commented Feb 12, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Feb 12, 2025

Uh oh!

openjdk bot commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zangcq commented Feb 12, 2025

Uh oh!

bridgekeeper bot commented Feb 12, 2025

Uh oh!

openjdk bot commented Feb 21, 2025

Uh oh!

mlbridge bot commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

zangcq commented Mar 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chhagedorn left a comment

Choose a reason for hiding this comment

Uh oh!

chhagedorn Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

zangcq Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

zangcq commented Mar 14, 2025

Uh oh!

zangcq commented Mar 18, 2025

Uh oh!

openjdk bot commented Mar 18, 2025

Uh oh!

zangcq commented Mar 18, 2025

Uh oh!

openjdk bot commented Mar 18, 2025

Uh oh!

zangcq commented Mar 18, 2025

Uh oh!

openjdk bot commented Mar 18, 2025

Uh oh!

bridgekeeper bot commented Apr 15, 2025

Uh oh!

zangcq commented May 6, 2025

Uh oh!

bridgekeeper bot commented Mar 11, 2026

Uh oh!

mrserb commented Mar 11, 2026

Uh oh!

openjdk bot commented Mar 11, 2026

Uh oh!

bridgekeeper bot commented Apr 9, 2026

Uh oh!

mrserb Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

zangcq Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

mrserb Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

zangcq commented Apr 13, 2026

Uh oh!

openjdk bot commented Apr 13, 2026

Uh oh!

jerboaa commented Apr 13, 2026

Uh oh!

openjdk bot commented Apr 13, 2026

Uh oh!

jerboaa commented Apr 13, 2026

zangcq commented Feb 12, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Feb 12, 2025 •

edited

Loading

mlbridge bot commented Mar 10, 2025 •

edited

Loading

zangcq commented Mar 12, 2025 •

edited

Loading

zangcq commented Apr 13, 2026 •

edited

Loading