Skip to content

Editors can now skip copyeditor acknowledgement emails#5250

Open
ajrbyers wants to merge 2 commits intomasterfrom
b-1027-bugfix
Open

Editors can now skip copyeditor acknowledgement emails#5250
ajrbyers wants to merge 2 commits intomasterfrom
b-1027-bugfix

Conversation

@ajrbyers
Copy link
Copy Markdown
Member

Closes #1027

  • Editors can now skip sending this message
  • It also now uses the email data class and has its own view/template to be consistent with others
  • Added some tests to ensure skipping skips 😄

@mauromsl mauromsl requested a review from joemull April 15, 2026 07:28
@mauromsl mauromsl removed their assignment Apr 15, 2026
@joemull joemull self-assigned this Apr 15, 2026
Copy link
Copy Markdown
Member

@joemull joemull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. I just noticed a couple things:

  • The HTML heading structure you use here is not accessible, but I assume you knew this and were copy-pasting a different existing template, with a plan to change all these later?
  • I tested it out and noticed that the view for re-opening the copyedit still uses the modal. In scope or out of scope?
    Image
  • Needs ruff formatting to pass CI

@joemull joemull assigned ajrbyers and unassigned joemull Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent behaviour/cannot skip sending message to copyeditor

3 participants