Skip to content

envtest-releases: add v1.35.1 to index#2748

Open
damdo wants to merge 1 commit intoopenshift:masterfrom
damdo:envtest-releases-bump-index-for-1.35
Open

envtest-releases: add v1.35.1 to index#2748
damdo wants to merge 1 commit intoopenshift:masterfrom
damdo:envtest-releases-bump-index-for-1.35

Conversation

@damdo
Copy link
Member

@damdo damdo commented Mar 6, 2026

Following up from the push I did to the bucket, this PR updates the index with those references.

@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2026

Hello @damdo! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@qodo-code-review
Copy link

Review Summary by Qodo

Add v1.35.1 envtest release to index

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Add v1.35.1 release to envtest index with platform binaries
• Update Makefile publish command to v1.35.1 with new payload
• Include darwin-amd64, darwin-arm64, linux-amd64, linux-arm64 builds
Diagram
flowchart LR
  A["v1.35.1 Release"] --> B["envtest-releases.yaml"]
  A --> C["tools/Makefile"]
  B --> D["4 Platform Binaries"]
  C --> E["Updated Publish Command"]
  D --> F["darwin-amd64"]
  D --> G["darwin-arm64"]
  D --> H["linux-amd64"]
  D --> I["linux-arm64"]
Loading

Grey Divider

File Changes

1. envtest-releases.yaml ⚙️ Configuration changes +13/-0

Add v1.35.1 release with platform binaries

• Add new v1.35.1 release section with four platform-specific binaries
• Include hash and selfLink for each binary artifact
• Binaries cover darwin-amd64, darwin-arm64, linux-amd64, linux-arm64 platforms

envtest-releases.yaml


2. tools/Makefile ⚙️ Configuration changes +1/-1

Update Makefile publish command to v1.35.1

• Update publish-kubebuilder-tools target version from v1.34.1 to v1.35.1
• Update OCP release payload from 4.21.0 to 4.22.0 with new CI build timestamp

tools/Makefile


Grey Divider

Qodo Logo

@qodo-code-review
Copy link

qodo-code-review bot commented Mar 6, 2026

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider


Remediation recommended

1. Version/payload mismatch risk 🐞 Bug ⛯ Reliability
Description
publish-kubebuilder-tools names and indexes artifacts solely from the provided -version string
and does not verify that the referenced payload actually contains that Kubernetes version, so an
incorrect payload tag in the Makefile can silently publish mislabeled envtest archives (leading to
confusing test failures for downstream consumers).
Code

tools/Makefile[40]

+	go run ./publish-kubebuilder-tools/main.go -version v1.35.1 -output-dir /tmp/kubebuilder-tools -payload=registry.ci.openshift.org/ocp/release:4.22.0-0.ci-2026-03-06-115610 -pull-secret $(PULL_SECRET) -index-file ../envtest-releases.yaml
Evidence
The Makefile pins both -version and -payload. In the publishing tool, -version is only
validated for a leading v and is then used to name archives, upload them, and write the index
entry; there is no cross-check against the payload’s Kubernetes version.

tools/Makefile[32-41]
tools/publish-kubebuilder-tools/main.go[47-99]
tools/publish-kubebuilder-tools/main.go[485-509]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`publish-kubebuilder-tools` will happily publish envtest archives labeled with `-version` even if the referenced `-payload` contains a different Kubernetes version. This makes it easy to accidentally publish incorrect artifacts and update the index with the wrong label.

### Issue Context
The Makefile target pins both `-version` and `-payload`, but the Go tool only validates that `-version` starts with `v` and then uses it for naming/upload/indexing. There is no verification step tying payload contents to the version label.

### Fix Focus Areas
- tools/publish-kubebuilder-tools/main.go[25-102]
- tools/publish-kubebuilder-tools/main.go[364-420]

### Suggested implementation directions
- After extracting `kube-apiserver`, run it with `--version` (or parse version metadata from the payload/artifacts if available) and compare to the requested `-version`.
- Fail fast with a clear error if they differ.
- Optionally also verify `etcd` version expectations if relevant.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@coderabbitai
Copy link

coderabbitai bot commented Mar 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro

Run ID: ff862659-b6ba-431e-8e6a-83d946c87164

📥 Commits

Reviewing files that changed from the base of the PR and between f595753 and 7604726.

📒 Files selected for processing (2)
  • envtest-releases.yaml
  • tools/Makefile

📝 Walkthrough

Walkthrough

This pull request updates Kubernetes version references from v1.34.1 to v1.35.1 across two files. The envtest-releases.yaml file adds a new release entry for v1.35.1 with platform-specific artifacts for darwin-amd64, darwin-arm64, linux-amd64, and linux-arm64, each including corresponding sha256 hashes and selfLinks. The tools/Makefile updates the publish-kubebuilder-tools target to reference the new v1.35.1 version and updates the OpenShift release payload from version 4.21.0 to 4.22.0, dated March 6, 2026.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding v1.35.1 to the envtest-releases index, which is exactly what the PR accomplishes.
Description check ✅ Passed The description is directly related to the changeset, explaining that it updates the index with release references for v1.35.1 following a prior bucket upload.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed This PR contains no Ginkgo test declarations requiring validation for stable and deterministic test names.
Test Structure And Quality ✅ Passed The custom check for Ginkgo test structure is not applicable to this PR as it only modifies configuration and Makefile files, not test code.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@damdo
Copy link
Member Author

damdo commented Mar 6, 2026

/assign @JoelSpeed @everettraven @nrb

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 6, 2026
@openshift-ci openshift-ci bot requested review from JoelSpeed and everettraven March 6, 2026 17:55
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2026

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants