Skip to content

OCPBUGS-60593: Skip oauth test for external control plane topology#30200

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
dinhxuanvu:hcp-header-test
Oct 9, 2025
Merged

OCPBUGS-60593: Skip oauth test for external control plane topology#30200
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
dinhxuanvu:hcp-header-test

Conversation

@dinhxuanvu
Copy link
Member

@dinhxuanvu dinhxuanvu commented Sep 2, 2025

For HyperShift, the control plane topology is external as control
plane components are not deployed in management cluster. As a result,
the oauth operator is unavailable and this test should be skipped.
Moving the topology check to the top before the cluster auth operator
check will ensure this test is skipped in external topology mode.

@dinhxuanvu dinhxuanvu changed the title Check for control-plane operator in hypershift for oauth test [WIP] Check for control-plane operator in hypershift for oauth test Sep 2, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2025
@dinhxuanvu
Copy link
Member Author

/payload-job periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-ovn-conformance-serial

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2025

@dinhxuanvu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-ovn-conformance-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/74f7ed50-8803-11f0-8764-482860b01723-0

@openshift-ci openshift-ci bot requested review from everettraven and liouk September 2, 2025 13:51
@dinhxuanvu dinhxuanvu changed the title [WIP] Check for control-plane operator in hypershift for oauth test OCPBUGS-60593: Check for control-plane operator in hypershift for oauth test Sep 3, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 3, 2025
@openshift-ci-robot
Copy link

@dinhxuanvu: This pull request references Jira Issue OCPBUGS-60593, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

In HyperShift env, cluster-authentication-operator doesn't run in management cluster. Instead, control-plane operator will handle authenication operations.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 3, 2025
@dinhxuanvu
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 3, 2025
@openshift-ci-robot
Copy link

@dinhxuanvu: This pull request references Jira Issue OCPBUGS-60593, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xingxingxia

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from xingxingxia September 3, 2025 14:27
@dinhxuanvu
Copy link
Member Author

@everettraven Hey Bryce, I think this PR is good to go unless you have any further comments. PTAL. Thanks.

@dinhxuanvu dinhxuanvu changed the title OCPBUGS-60593: Check for control-plane operator in hypershift for oauth test OCPBUGS-60593: Skip oauth test for external control plane topology Sep 9, 2025
@openshift-ci-robot
Copy link

@dinhxuanvu: This pull request references Jira Issue OCPBUGS-60593, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xingxingxia

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

For HyperShift, the control plane topology is external as control
plane components are not deployed in management cluster. As a result,
the oauth operator is unavailable and this test should be skipped.
Moving the topology check to the top before the cluster auth operator
check will ensure this test is skipped in external topology mode.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

For HyperShift, the control plane topology is external as control
plane components are not deployed in management cluster. As a result,
the oauth operator is unavailable and this test should be skipped.
Moving the topology check to the top before the cluster auth operator
check will ensure this test is skipped in external topology mode.

Signed-off-by: Vu Dinh <vudinh@outlook.com>
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, everettraven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2025
@dinhxuanvu
Copy link
Member Author

/retest-required

@openshift-ci-robot
Copy link

/hold

Revision 02635e1 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2025
@dinhxuanvu
Copy link
Member Author

/retest-required

1 similar comment
@dinhxuanvu
Copy link
Member Author

/retest-required

@dinhxuanvu
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3581fe4 and 2 for PR HEAD 02635e1 in total

@dinhxuanvu
Copy link
Member Author

/retest e2e-aws-ovn-microshift

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 8, 2025

@dinhxuanvu: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test e2e-aws-csi
/test e2e-aws-jenkins
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-image-registry
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-builds
/test e2e-gcp-ovn-image-ecosystem
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi
/test images
/test lint
/test okd-scos-images
/test unit
/test verify
/test verify-deps

The following commands are available to trigger optional jobs:

/test e2e-agnostic-ovn-cmd
/test e2e-aws-disruptive
/test e2e-aws-etcd-certrotation
/test e2e-aws-etcd-recovery
/test e2e-aws-ovn
/test e2e-aws-ovn-cgroupsv2
/test e2e-aws-ovn-edge-zones
/test e2e-aws-ovn-etcd-scaling
/test e2e-aws-ovn-kube-apiserver-rollout
/test e2e-aws-ovn-kubevirt
/test e2e-aws-ovn-serial-fast
/test e2e-aws-ovn-serial-ipsec
/test e2e-aws-ovn-serial-publicnet-1of2
/test e2e-aws-ovn-serial-publicnet-2of2
/test e2e-aws-ovn-single-node
/test e2e-aws-ovn-single-node-serial
/test e2e-aws-ovn-single-node-techpreview
/test e2e-aws-ovn-single-node-techpreview-serial
/test e2e-aws-ovn-single-node-upgrade
/test e2e-aws-ovn-upgrade
/test e2e-aws-ovn-upgrade-rollback
/test e2e-aws-ovn-upi
/test e2e-aws-proxy
/test e2e-azure
/test e2e-azure-ovn-etcd-scaling
/test e2e-azure-ovn-upgrade
/test e2e-baremetalds-kubevirt
/test e2e-external-aws
/test e2e-external-aws-ccm
/test e2e-external-vsphere-ccm
/test e2e-gcp-disruptive
/test e2e-gcp-fips-serial-1of2
/test e2e-gcp-fips-serial-2of2
/test e2e-gcp-ovn-etcd-scaling
/test e2e-gcp-ovn-rt-upgrade
/test e2e-gcp-ovn-techpreview
/test e2e-gcp-ovn-techpreview-serial-1of2
/test e2e-gcp-ovn-techpreview-serial-2of2
/test e2e-gcp-ovn-usernamespace
/test e2e-hypershift-conformance
/test e2e-metal-ipi-ovn
/test e2e-metal-ipi-ovn-bgp-virt-dualstack
/test e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-dualstack-bgp
/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw
/test e2e-metal-ipi-ovn-dualstack-local-gateway
/test e2e-metal-ipi-ovn-kube-apiserver-rollout
/test e2e-metal-ipi-serial-1of2
/test e2e-metal-ipi-serial-2of2
/test e2e-metal-ipi-serial-ovn-ipv6-1of2
/test e2e-metal-ipi-serial-ovn-ipv6-2of2
/test e2e-metal-ipi-virtualmedia
/test e2e-metal-ovn-single-node-live-iso
/test e2e-metal-ovn-single-node-with-worker-live-iso
/test e2e-metal-ovn-two-node-arbiter
/test e2e-metal-ovn-two-node-fencing
/test e2e-openstack-ovn
/test e2e-openstack-serial
/test e2e-test-image-stream-import-mode-techpreview
/test e2e-vsphere-ovn-dualstack-primaryv6
/test e2e-vsphere-ovn-etcd-scaling
/test okd-scos-e2e-aws-ovn

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-origin-main-e2e-aws-csi
pull-ci-openshift-origin-main-e2e-aws-ovn-fips
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-2of2
pull-ci-openshift-origin-main-e2e-gcp-csi
pull-ci-openshift-origin-main-e2e-gcp-ovn
pull-ci-openshift-origin-main-e2e-gcp-ovn-upgrade
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6
pull-ci-openshift-origin-main-e2e-vsphere-ovn
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi
pull-ci-openshift-origin-main-images
pull-ci-openshift-origin-main-lint
pull-ci-openshift-origin-main-okd-scos-e2e-aws-ovn
pull-ci-openshift-origin-main-okd-scos-images
pull-ci-openshift-origin-main-unit
pull-ci-openshift-origin-main-verify
pull-ci-openshift-origin-main-verify-deps
Details

In response to this:

/retest e2e-aws-ovn-microshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dinhxuanvu
Copy link
Member Author

/test e2e-aws-ovn-microshift

@dinhxuanvu
Copy link
Member Author

/test e2e-aws-ovn-serial-2of2

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d3b6fa6 and 1 for PR HEAD 02635e1 in total

@dinhxuanvu
Copy link
Member Author

/test e2e-aws-ovn-serial-2of2

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 816619b and 0 for PR HEAD 02635e1 in total

@openshift-ci-robot
Copy link

/hold

Revision 02635e1 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 9, 2025

@dinhxuanvu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-proxy 02635e1 link false /test e2e-aws-proxy
ci/prow/e2e-aws-disruptive 02635e1 link false /test e2e-aws-disruptive
ci/prow/e2e-openstack-ovn 02635e1 link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn 02635e1 link false /test e2e-aws-ovn
ci/prow/e2e-azure 02635e1 link false /test e2e-azure
ci/prow/e2e-aws-ovn-kube-apiserver-rollout 02635e1 link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-hypershift-conformance 02635e1 link false /test e2e-hypershift-conformance
ci/prow/e2e-aws-ovn-single-node-upgrade 02635e1 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node-serial 02635e1 link false /test e2e-aws-ovn-single-node-serial
ci/prow/okd-scos-e2e-aws-ovn 02635e1 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp-ovn-techpreview-serial-2of2 02635e1 link false /test e2e-gcp-ovn-techpreview-serial-2of2
ci/prow/e2e-agnostic-ovn-cmd 02635e1 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout 02635e1 link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/e2e-metal-ipi-virtualmedia 02635e1 link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-aws-ovn-edge-zones 02635e1 link false /test e2e-aws-ovn-edge-zones
ci/prow/e2e-aws-ovn-cgroupsv2 02635e1 link false /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-aws-ovn-single-node 02635e1 link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-trt
Copy link

openshift-trt bot commented Oct 9, 2025

Job Failure Risk Analysis for sha: 02635e1

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 IncompleteTests
Tests for this run (123) are below the historical average (1522): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-openstack-ovn IncompleteTests
Tests for this run (28) are below the historical average (2293): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@openshift-trt
Copy link

openshift-trt bot commented Oct 9, 2025

Job Failure Risk Analysis for sha: 02635e1

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 IncompleteTests
Tests for this run (123) are below the historical average (1525): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-openstack-ovn IncompleteTests
Tests for this run (28) are below the historical average (2293): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@dinhxuanvu
Copy link
Member Author

/retest-required

@dinhxuanvu
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7343864 and 2 for PR HEAD 02635e1 in total

@openshift-merge-bot openshift-merge-bot bot merged commit bb9f65a into openshift:main Oct 9, 2025
30 of 47 checks passed
@openshift-ci-robot
Copy link

@dinhxuanvu: Jira Issue Verification Checks: Jira Issue OCPBUGS-60593
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-60593 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

For HyperShift, the control plane topology is external as control
plane components are not deployed in management cluster. As a result,
the oauth operator is unavailable and this test should be skipped.
Moving the topology check to the top before the cluster auth operator
check will ensure this test is skipped in external topology mode.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.21.0-0.nightly-2025-10-12-115019

@alebedev87
Copy link
Contributor

/cherry-pick release-4.20

@openshift-cherrypick-robot

@alebedev87: new pull request created: #30848

Details

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants