Skip to content

DNM/SPLAT-2672: e2e/ote/ccm-aws: moving binary cccmo project#30864

Draft
mtulio wants to merge 1 commit intoopenshift:mainfrom
mtulio:e2e-ote-ccm-aws
Draft

DNM/SPLAT-2672: e2e/ote/ccm-aws: moving binary cccmo project#30864
mtulio wants to merge 1 commit intoopenshift:mainfrom
mtulio:e2e-ote-ccm-aws

Conversation

@mtulio
Copy link
Contributor

@mtulio mtulio commented Mar 11, 2026

WRT openshift/cluster-cloud-controller-manager-operator#437

SPLAT-2672

Summary by CodeRabbit

  • Chores
    • Updated test extension registry entries for AWS cloud controller manager tests to use the revised image name and updated binary path.

@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 11, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 11, 2026

@mtulio: This pull request references SPLAT-2672 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

WRT openshift/cluster-cloud-controller-manager-operator#437

SPLAT-2672

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 11, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link

coderabbitai bot commented Mar 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8cf9bf92-04eb-4ed4-b7a3-b52875436326

📥 Commits

Reviewing files that changed from the base of the PR and between ac0c863 and 61ad58e.

📒 Files selected for processing (1)
  • pkg/test/extensions/binary.go
🚧 Files skipped from review as they are similar to previous changes (1)
  • pkg/test/extensions/binary.go

Walkthrough

Updates a single test extension registry entry in pkg/test/extensions/binary.go, changing the AWS cloud controller manager image tag and the associated binary path; no control-flow or logic changes.

Changes

Cohort / File(s) Summary
AWS Test Extension Registry
pkg/test/extensions/binary.go
Updated imageTag from "aws-cloud-controller-manager" to "cluster-cloud-controller-manager-operator" and binaryPath from "/usr/bin/aws-cloud-controller-manager-tests-ext.gz" to "/usr/bin/cloud-controller-manager-aws-tests-ext.gz".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title references moving a binary for the ccm-aws (cloud controller manager AWS) project, which aligns with the actual changes that update imageTag and binaryPath in the extension binaries registry for AWS cloud controller manager tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed The file contains no Ginkgo test definitions and changes are configuration entries mapping image tags to binary paths, not test titles with dynamic information.
Test Structure And Quality ✅ Passed The PR modifies only configuration registry data in binary.go, not Ginkgo test code. The custom check for test code quality is not applicable to configuration/metadata updates.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 11, 2026

@mtulio: This pull request references SPLAT-2672 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

WRT openshift/cluster-cloud-controller-manager-operator#437

SPLAT-2672

Summary by CodeRabbit

  • Chores
  • Updated test extension registry entries for AWS cloud controller manager tests, including associated binary identifiers and file paths to reflect current deployment configuration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 11, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mtulio
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 12, 2026

@mtulio: This pull request references SPLAT-2672 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

WRT openshift/cluster-cloud-controller-manager-operator#437

SPLAT-2672

Summary by CodeRabbit

  • Chores
  • Updated test extension registry entries for AWS cloud controller manager tests to use the revised image name and updated binary path.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants