telco: cnf-features-deploy: test tools image on PR ref#76077
telco: cnf-features-deploy: test tools image on PR ref#76077shajmakh wants to merge 1 commit intoopenshift:mainfrom
Conversation
ci-operator by design uses base image `build_root` for all the test lanes where relevant. However that root image is built from master's head not the PR's branch. The problem is that the changes of the tools image will not be applied to the testing env even when it is part of the PR. The best option we can do to at least minimize the impact of build-root limitation is building the image as part of `images` stanza and control the base (fedora) in prow rather than in the kni repo. Signed-off-by: Shereen Haj <shajmakh@redhat.com>
|
[REHEARSALNOTIFIER]
A total of 60 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shajmakh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/pj-rehearse pull-ci-openshift-kni-cnf-features-deploy-master-images |
|
@shajmakh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@shajmakh: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
ci-operator by design uses base image
build_rootfor all the test lanes where relevant. However that root image is built from master's head not the PR's branch.The problem is that the changes of the tools image will not be applied to the testing env even when it is part of the PR.
The best option we can do to at least minimize the impact of build-root limitation is building the image as part of
imagesstanza and control the base (fedora) in prow rather than in the kni repo.