Skip to content

make set-cluster-version-spec-update-service works with a custom payload image#76086

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
jianlinliu:custom-payload-enhance
Mar 12, 2026
Merged

make set-cluster-version-spec-update-service works with a custom payload image#76086
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
jianlinliu:custom-payload-enhance

Conversation

@jianlinliu
Copy link
Contributor

@jianlinliu jianlinliu commented Mar 11, 2026

when users specify a custom payload (e.g: registry.ci.openshift.org/ocp/release:4.22.0-0.nightly-2026-03-10-100251) to run testing, oc adm release command in set-cluster-version-spec-update-service will fail to authenticate to access the payload (not a build farm build image). Fix it to use cluster profile's pull-secret to pass the authentication.

slack thread is here.

@openshift-ci openshift-ci bot requested review from gpei and stbenjam March 11, 2026 13:06
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2026
@jianlinliu
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-f7-longduration-hive-remaining

@openshift-ci-robot
Copy link
Contributor

@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jianlinliu
Copy link
Contributor Author

jianlinliu commented Mar 11, 2026

@xingxingxia I did some test as your case, it works now, the log is here.

@jianlinliu
Copy link
Contributor Author

/pj-rehearse abort

@openshift-ci-robot
Copy link
Contributor

@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jianlinliu jianlinliu force-pushed the custom-payload-enhance branch from 825bed2 to ade9401 Compare March 11, 2026 14:51
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jianlinliu: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-kube-state-metrics-main-e2e-agnostic-cmo openshift/kube-state-metrics presubmit Registry content changed
pull-ci-openshift-kube-state-metrics-main-ginkgo-tests-cmo openshift/kube-state-metrics presubmit Registry content changed
pull-ci-openshift-kube-state-metrics-release-5.0-e2e-agnostic-cmo openshift/kube-state-metrics presubmit Registry content changed
pull-ci-openshift-kube-state-metrics-release-5.0-ginkgo-tests-cmo openshift/kube-state-metrics presubmit Registry content changed
pull-ci-openshift-kube-state-metrics-release-4.23-e2e-agnostic-cmo openshift/kube-state-metrics presubmit Registry content changed
pull-ci-openshift-kube-state-metrics-release-4.23-ginkgo-tests-cmo openshift/kube-state-metrics presubmit Registry content changed
pull-ci-openshift-kube-state-metrics-release-4.22-e2e-agnostic-cmo openshift/kube-state-metrics presubmit Registry content changed
pull-ci-openshift-kube-state-metrics-release-4.22-ginkgo-tests-cmo openshift/kube-state-metrics presubmit Registry content changed
pull-ci-openshift-kube-state-metrics-release-4.21-e2e-agnostic-cmo openshift/kube-state-metrics presubmit Registry content changed
pull-ci-openshift-kube-state-metrics-release-4.21-ginkgo-tests-cmo openshift/kube-state-metrics presubmit Registry content changed
pull-ci-openshift-kube-state-metrics-release-4.20-e2e-agnostic-cmo openshift/kube-state-metrics presubmit Registry content changed
pull-ci-openshift-kube-state-metrics-release-4.19-e2e-agnostic-cmo openshift/kube-state-metrics presubmit Registry content changed
pull-ci-openshift-kube-state-metrics-release-4.18-e2e-agnostic-cmo openshift/kube-state-metrics presubmit Registry content changed
pull-ci-openshift-kube-state-metrics-release-4.17-e2e-agnostic-cmo openshift/kube-state-metrics presubmit Registry content changed
pull-ci-openshift-kube-state-metrics-release-4.16-e2e-agnostic-cmo openshift/kube-state-metrics presubmit Registry content changed
pull-ci-openshift-kube-state-metrics-release-4.15-e2e-agnostic-cmo openshift/kube-state-metrics presubmit Registry content changed
pull-ci-openshift-kube-state-metrics-release-4.14-e2e-agnostic-cmo openshift/kube-state-metrics presubmit Registry content changed
pull-ci-openshift-kube-state-metrics-release-4.13-e2e-agnostic-cmo openshift/kube-state-metrics presubmit Registry content changed
pull-ci-openshift-kube-state-metrics-release-4.12-e2e-agnostic-cmo openshift/kube-state-metrics presubmit Registry content changed
pull-ci-openshift-kube-state-metrics-release-4.11-e2e-agnostic-cmo openshift/kube-state-metrics presubmit Registry content changed
pull-ci-openshift-kube-state-metrics-release-4.10-e2e-agnostic-cmo openshift/kube-state-metrics presubmit Registry content changed
pull-ci-openshift-kube-state-metrics-release-4.9-e2e-agnostic-cmo openshift/kube-state-metrics presubmit Registry content changed
pull-ci-openshift-kube-state-metrics-main-e2e-aws openshift/kube-state-metrics presubmit Registry content changed
pull-ci-openshift-kube-state-metrics-main-okd-scos-e2e-aws-ovn openshift/kube-state-metrics presubmit Registry content changed
pull-ci-openshift-kube-state-metrics-release-5.0-e2e-aws openshift/kube-state-metrics presubmit Registry content changed

A total of 28357 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jianlinliu
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-4.18-e2e-aws-ovn-serial periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-rt-upgrade periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-upgrade periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv4 periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-stable-4.19-upgrade-from-stable-4.18-aws-usgov-ipi-private-sts-f28

@openshift-ci-robot
Copy link
Contributor

@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@jianlinliu: job(s): periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-rt-upgrade, periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-upgrade, , periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv4, either don't exist or were not found to be affected, and cannot be rehearsed

@jianlinliu
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 12, 2026
@jianlinliu
Copy link
Contributor Author

@yunjiang29 can you help review it ?

@jianlinliu
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@yunjiang29
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianlinliu, yunjiang29

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 12, 2026

@jianlinliu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview ade9401 link unknown /pj-rehearse periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0a35e6b into openshift:main Mar 12, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants