Fix odh-model-controller kustomize manifest path resolution#76097
Conversation
The kserve e2e test was using $(pwd)/config/base as the manifest source, but in the CI pod the working directory does not contain the odh-model-controller checkout. This caused kustomize to fail with: evalsymlink failure on '/go/config/base': lstat /go/config: no such file or directory: new root '/go/config/base' cannot be absolute Fix by explicitly cloning the odh-model-controller repo at the tested branch/ref before pointing ODH_MC_MANIFEST_SOURCE at the checkout. Applied to all three branch configs: main, incubating, stable-2.x. Made-with: Cursor
|
/pj-rehearse auto-ack |
|
@jlost: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci
bot
added
lgtm
The CI pod's /go/ directory is not writable, and REPO_OWNER/REPO_NAME resolve to openshift/release (the repo hosting the CI config), not opendatahub-io/odh-model-controller. Hardcode the correct repo URL and branch per config, and clone into /tmp/ which is always writable. Made-with: Cursor
|
/pj-rehearse auto-ack |
|
@jlost: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse auto-ack |
|
@jlost: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Kustomize rejects absolute paths as resource roots. Clone odh-model-controller inside the kserve tree and use a relative path so that the generated kustomization.yaml in bin/odh-mc-kustomize/ can resolve it correctly. Made-with: Cursor
|
/pj-rehearse auto-ack |
|
@jlost: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/retest |
|
/pj-rehearse auto-ack |
|
@spolti: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlost, spolti The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@jlost: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
…t#76097) * Fix odh-model-controller kustomize manifest path resolution The kserve e2e test was using $(pwd)/config/base as the manifest source, but in the CI pod the working directory does not contain the odh-model-controller checkout. This caused kustomize to fail with: evalsymlink failure on '/go/config/base': lstat /go/config: no such file or directory: new root '/go/config/base' cannot be absolute Fix by explicitly cloning the odh-model-controller repo at the tested branch/ref before pointing ODH_MC_MANIFEST_SOURCE at the checkout. Applied to all three branch configs: main, incubating, stable-2.x. Made-with: Cursor * Fix clone target: use /tmp, hardcode repo URL and branch The CI pod's /go/ directory is not writable, and REPO_OWNER/REPO_NAME resolve to openshift/release (the repo hosting the CI config), not opendatahub-io/odh-model-controller. Hardcode the correct repo URL and branch per config, and clone into /tmp/ which is always writable. Made-with: Cursor * Fix kustomize absolute path error in ODH_MC_MANIFEST_SOURCE Kustomize rejects absolute paths as resource roots. Clone odh-model-controller inside the kserve tree and use a relative path so that the generated kustomization.yaml in bin/odh-mc-kustomize/ can resolve it correctly. Made-with: Cursor
3 participants
Summary
$(pwd)/config/baseas the manifest source (ODH_MC_MANIFEST_SOURCE), but in the CI pod the working directory (/go) does not contain the odh-model-controller checkout, causing kustomize to fail:/go/odh-model-controllerbefore setting the manifest source path.main,incubating,stable-2.x.Test plan
Made with Cursor